Do not allow a linktobranch for metapackages like _pattern

Fixes #17305
openSUSE · Jan 30, 2025 · 0500eac · 0500eac
1 parent 29e0459
commit 0500eac
Show file tree

Hide file tree

Showing 4 changed files with 611 additions and 0 deletions.
diff --git a/src/api/app/controllers/source_controller.rb b/src/api/app/controllers/source_controller.rb
@@ -1068,6 +1068,10 @@ def package_command_deleteuploadrev
 
   # POST /source/<project>/<package>?cmd=linktobranch
   def package_command_linktobranch
+    if @package.nil?
+      render_error status: 400, message: 'package is not a link'
+      return
+    end
     pkg_rev = params[:rev]
     pkg_linkrev = params[:linkrev]
 

diff --git a/...ssettes/SourceController/POST_linktobranch/when_accessing_a__patterns_package/1_7_2_1.yml b/...ssettes/SourceController/POST_linktobranch/when_accessing_a__patterns_package/1_7_2_1.yml