Support the labeled/unlabeled actions on pull_request events #17373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
reviewed
Feb 12, 2025
|
|
||
| def pull_request_unlabeled? | ||
| github_pull_request_unlabeled? | ||
| end |
There was a problem hiding this comment.
All of this will barf it it's gitlab. And what about gitea?
There was a problem hiding this comment.
Also, all the other methods use different naming scheme.
- reopened_pull_request?
- pull_request_unlabeled?
There was a problem hiding this comment.
Nothing breaks for gitlab. The code to execute label filter just does not execute.
I will address the naming convention change you mentioned
There was a problem hiding this comment.
You are still using a different naming scheme...
hennevogel
reviewed
Feb 12, 2025
rubhanazeem
force-pushed
the
scm/ci-labels
branch
3 times, most recently
from
d22144f to
f2db237
Compare
hennevogel
reviewed
Feb 13, 2025
hennevogel
reviewed
Feb 13, 2025
rubhanazeem
force-pushed
the
scm/ci-labels
branch
from
f2db237 to
2d6fe04
Compare
rubhanazeem
force-pushed
the
scm/ci-labels
branch
2 times, most recently
from
7cad0cc to
20ce90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.