Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace payload hashes with fixtures #17377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace payload hashes with fixtures #17377

wants to merge 2 commits into from
+444 −868

Conversation

hellcp-work
Copy link
Contributor

Simplifies viewing and writing tests by moving data outside of them.

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Feb 13, 2025
@eduardoj
Copy link
Member

The first commit introduces the file src/api/spec/services/trigger_controller_service/scm_extractor_spec.rb. However, the second commit removes it...

eduardoj
eduardoj requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@eduardoj eduardoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoj eduardoj eduardoj requested changes

@ncounter ncounter ncounter approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellcp-work @eduardoj @ncounter