-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osclib: provide ConfigCommand and expose via osc-staging (utilize in repo_checker) #1189
Conversation
@DimStar77 this provides the workaround you were looking for with a fairly nice interface to see all such additions. I would expect your normal usage to be:
|
An overview of all such changes being easy to view using:
or
|
@jberry-suse That command line interface looks ok; I can certainly live with that. and as it's a part of the config, it should be rather simple to extend 'osc staging freeze and osc staging adi to reset their special config (freeze usually means the leaks are gone, and adi, well, would reset when a prj is deleted (ready to accept) |
Was there something you had in mind? This provides every sort of read/write/clear/append combination that would seem useful. Far more than minimal read/write or manually edit psudometa. |
The problem can still be resolved by making the install requirements policy consistent with build requirements policy. |
f35d8c1
to
95dc2fe
Compare
Added the freeze bit to clear staging config. |
95dc2fe
to
cbd61d0
Compare
👍 The most common issue seen lately are i586 issues for ring2 - and I'm still not willing to add i586 to ring2 (:DVD) builds - unless somebody sponsors another 100 dedicated workers for Stagings But with the interface to add ignores for a staging that are wiped on rebase, we at least get accurate info of what is there for which stagings. |
LGTM |
1e39042:
repo_checker: filter empty whitelist entries.
f0ff9cb:
repo_checker: utilize staging configuration for whitelist additions.
d2b50c0:
osclib: provide ConfigCommand and expose via osc-staging.
336a0e5:
osclib/stagingapi: get_staging_projects(): provide include_dvd option.
I played around with various approaches for modifying
osclib/conf.py
to be able to apply staging config, but given that for therepo_checker
use-case the values are to be appended and I cannot foresee trivial uses of this elsewhere I left it up to utilizing code to use the values. Currently, the config can only be loaded with project level overrides since a project is always being operated on, but stagings are mixed in many commands and there does not appear to be a clear way to implement automatically nor a real reason for it. Once we come across a second desirable case hopefully this will be more obvious. The the usage inrepo_checker
is quite trivial.Fixes #1122.