Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib: provide ConfigCommand and expose via osc-staging (utilize in repo_checker) #1189

Merged
merged 6 commits into from
Oct 13, 2017

Conversation

jberry-suse
Copy link
Contributor

@jberry-suse jberry-suse commented Oct 11, 2017

  • 1e39042:
    repo_checker: filter empty whitelist entries.

  • f0ff9cb:
    repo_checker: utilize staging configuration for whitelist additions.

  • d2b50c0:
    osclib: provide ConfigCommand and expose via osc-staging.

  • 336a0e5:
    osclib/stagingapi: get_staging_projects(): provide include_dvd option.

I played around with various approaches for modifying osclib/conf.py to be able to apply staging config, but given that for the repo_checker use-case the values are to be appended and I cannot foresee trivial uses of this elsewhere I left it up to utilizing code to use the values. Currently, the config can only be loaded with project level overrides since a project is always being operated on, but stagings are mixed in many commands and there does not appear to be a clear way to implement automatically nor a real reason for it. Once we come across a second desirable case hopefully this will be more obvious. The the usage in repo_checker is quite trivial.

Fixes #1122.

@jberry-suse
Copy link
Contributor Author

@DimStar77 this provides the workaround you were looking for with a fairly nice interface to see all such additions. I would expect your normal usage to be:

osc staging config --append C D E adi:17 repo_checker-binary-whitelist leaky-dep-to-avoid-rebase

@jberry-suse
Copy link
Contributor Author

jberry-suse commented Oct 11, 2017

An overview of all such changes being easy to view using:

osc staging config

or

osc staging config repo_checker-binary-whitelist

@openSUSE openSUSE deleted a comment from coveralls Oct 11, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 47.235% when pulling f35d8c1 on jberry-suse:staging-config into a2ba667 on openSUSE:master.

@DimStar77
Copy link
Contributor

@jberry-suse That command line interface looks ok; I can certainly live with that.

and as it's a part of the config, it should be rather simple to extend 'osc staging freeze and osc staging adi to reset their special config (freeze usually means the leaks are gone, and adi, well, would reset when a prj is deleted (ready to accept)

@jberry-suse
Copy link
Contributor Author

jberry-suse commented Oct 12, 2017

Was there something you had in mind? This provides every sort of read/write/clear/append combination that would seem useful. Far more than minimal read/write or manually edit psudometa.

@jberry-suse
Copy link
Contributor Author

The problem can still be resolved by making the install requirements policy consistent with build requirements policy.

@jberry-suse
Copy link
Contributor Author

Added the freeze bit to clear staging config.

@openSUSE openSUSE deleted a comment from coveralls Oct 12, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 47.236% when pulling cbd61d0 on jberry-suse:staging-config into a2ba667 on openSUSE:master.

@DimStar77
Copy link
Contributor

👍

The most common issue seen lately are i586 issues for ring2 - and I'm still not willing to add i586 to ring2 (:DVD) builds - unless somebody sponsors another 100 dedicated workers for Stagings

But with the interface to add ignores for a staging that are wiped on rebase, we at least get accurate info of what is there for which stagings.

@nilxam
Copy link
Contributor

nilxam commented Oct 13, 2017

LGTM

@nilxam nilxam merged commit aeef41f into openSUSE:master Oct 13, 2017
@jberry-suse jberry-suse deleted the staging-config branch October 16, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants