Skip to content

Commit

Permalink
Better deprecation notices (#19)
Browse files Browse the repository at this point in the history
  • Loading branch information
openactive-bot authored Mar 2, 2021
1 parent a24dcb5 commit e00e020
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
6 changes: 3 additions & 3 deletions OpenActive.NET.Generator/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion OpenActive.NET.Generator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"author": "Nick Evans",
"license": "MIT",
"dependencies": {
"@openactive/data-models": "^2.0.179",
"@openactive/data-models": "^2.0.180",
"fs-extra": "^7.0.1",
"sync-request": "^6.0.0"
}
Expand Down
3 changes: 2 additions & 1 deletion OpenActive.NET/models/Offer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,12 @@ public override string ToString()


/// <summary>
/// DEPRECATED: Please use `oa:ageRestriction` instead when describing an `Offer`.
/// [DEPRECATED: Use `ageRestriction` instead of `ageRange` within the `Offer` for cases where the `Offer` is age restricted.]
/// Indicates that an Offer is only applicable to a specific age range.
/// </summary>
[DataMember(Name = "ageRange", EmitDefaultValue = false, Order = 12)]
[JsonConverter(typeof(ValuesConverter))]
[Obsolete("Use `ageRestriction` instead of `ageRange` within the `Offer` for cases where the `Offer` is age restricted.", false)]
public virtual QuantitativeValue AgeRange { get; set; }


Expand Down
3 changes: 2 additions & 1 deletion OpenActive.NET/models/PartialSchedule.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,14 @@ public override string ToString()


/// <summary>
/// [NOTICE: This is a beta property, and is highly likely to change in future versions of this library.]
/// [DEPRECATED: This term has graduated from the beta namespace and is highly likely to be removed in future versions of this library, please use `scheduleTimezone` instead.]
/// The time zone used to generate occurrences, same as iCal TZID. E.g. 'Europe/London'.
///
/// If you are using this property, please join the discussion at proposal [#197](https://github.com/openactive/modelling-opportunity-data/issues/197).
/// </summary>
[DataMember(Name = "beta:timeZone", EmitDefaultValue = false, Order = 1009)]
[JsonConverter(typeof(ValuesConverter))]
[Obsolete("This term has graduated from the beta namespace and is highly likely to be removed in future versions of this library, please use `scheduleTimezone` instead.", false)]
public override string TimeZone { get; set; }

}
Expand Down
3 changes: 2 additions & 1 deletion OpenActive.NET/models/Schedule.cs
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,14 @@ public override string ToString()


/// <summary>
/// [NOTICE: This is a beta property, and is highly likely to change in future versions of this library.]
/// [DEPRECATED: This term has graduated from the beta namespace and is highly likely to be removed in future versions of this library, please use `scheduleTimezone` instead.]
/// The time zone used to generate occurrences, same as iCal TZID. E.g. 'Europe/London'.
///
/// If you are using this property, please join the discussion at proposal [#197](https://github.com/openactive/modelling-opportunity-data/issues/197).
/// </summary>
[DataMember(Name = "beta:timeZone", EmitDefaultValue = false, Order = 1022)]
[JsonConverter(typeof(ValuesConverter))]
[Obsolete("This term has graduated from the beta namespace and is highly likely to be removed in future versions of this library, please use `scheduleTimezone` instead.", false)]
public virtual string TimeZone { get; set; }

}
Expand Down

0 comments on commit e00e020

Please sign in to comment.