Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional cicd npm version major #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Reikyo
Copy link

@Reikyo Reikyo commented Nov 12, 2024

Allowing for NPM major version to only be incremented on changes to src/templates/, using the paths-filter custom action to act at the step-level rather than the full workflow-level. This will then allow for PR 8(2023-03-15) to be finalised, as also seen in the issue board here and here.

Use the paths-filter custom action to check on changes to src/templates/, and if this has occurred then update NPM major version.
Clarified nomenclature to show the exact location of changes being observed by the paths-filter custom action.
@howaskew
Copy link

@Reikyo Looks like the readme will need updating also. And though not mentioned in Contribution as it is in other repos, you could follow the conventional commits approach.

@Reikyo
Copy link
Author

Reikyo commented Nov 13, 2024

@howaskew How would you suggest the readme to be updated? This change complies with what's already stated in the Releasing section of the readme.

In fact, checking that section has prompted an additional change which is needed. This commit as it stands only checks for changes to src/templates/, but it should also check for changes to src/static/. From the readme wording, it's actually unclear if it should also check for changes to src/templateRenderer/, I'm assuming yes but would be good to have this confirmed.

@howaskew
Copy link

@Reikyo Just that last line:

NOTE: All commits to master currently trigger a major version bump in CI by default.

That's no longer the case with this fix?

@Reikyo
Copy link
Author

Reikyo commented Nov 13, 2024

@howaskew Yes good spot, thanks for flagging.

@Reikyo
Copy link
Author

Reikyo commented Nov 13, 2024

@howaskew I've updated the trigger condition to work on src/static/ as well as src/templates/, and have adjusted the readme to reflect the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants