fix: Reset TTY on exit #2287
Annotations
2 errors and 19 warnings
|
|
|
Run OpenActive Integration Tests in random mode
The operation was canceled.
|
|
Build .NET Core Booking Server Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Avoid empty interfaces [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Exceptions should be public [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message). [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException). [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic) [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Consider calling ConfigureAwait on the awaited task [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Booking Server Reference Implementation
Consider calling ConfigureAwait on the awaited task [/home/runner/work/openactive-test-suite/openactive-test-suite/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Fakes/OpenActive.FakeDatabase.NET/OpenActive.FakeDatabase.NET.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
Unreachable code detected [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Fakes/OpenActive.FakeDatabase.NET/OpenActive.FakeDatabase.NET.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
|
Build .NET Core Authentication Authority Reference Implementation
Unreachable code detected [/home/runner/work/openactive-test-suite/openactive-test-suite/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "controlled.facilityuse-has-slots.simple", "controlled.no-auth.approval", "controlled.no-auth.simple", "controlled.no-payment-reconciliation.simple", "controlled.no-tax-calculation.simple", "controlled.prepayment-always-required.simple", "controlled.single-seller.simple", "random.all-features.simple", "random.facilityuse-has-slots.simple", "random.no-auth.approval", "random.no-auth.simple", "random.no-payment-reconciliation.simple", "random.no-tax-calculation.approval", "random.no-tax-calculation.simple", "random.prepayment-always-required.simple", "random.single-seller.approval".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Loading