docs: Describe how to test against a local Reference Implementation #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehesluke
requested review from
nickevansuk,
civsiv and
NemanjaStefanovic
nickevansuk
requested changes
Oct 6, 2020
| ```json | ||
| "datasetSiteUrl": "http://localhost:55603/openactive" | ||
| ``` | ||
| 3. Update `sellers` in your local integration tests config (packages/openactive-integration-tests/config/local.json) to reflect the local seller URLs. |
There was a problem hiding this comment.
Suggested change
| 3. Update `sellers` in your local integration tests config (packages/openactive-integration-tests/config/local.json) to reflect the local seller URLs. | |
| 3. Update `sellers` in your [local integration tests config](./#local-configuration) (packages/openactive-integration-tests/config/local.json) to reflect the local seller URLs. |
as it's not always obvious what local.json is from a cursory glance
| It is often helpful to run the tests against a local copy of the Reference Implementation. In order to do this: | ||
|
|
||
| 1. Run the Reference Implementation (`Examples/BookingSystem.AspNetCore` in [OpenActive.Server.NET](https://github.com/openactive/OpenActive.Server.NET/)) locally. | ||
| 2. Update `datasetSiteUrl` in your local broker config (packages/openactive-broker-microservice/config/local.json) to point to the local Reference Implementation's `/openactive` URL e.g. (ports are assigned randomly by .NET, so yours will differ from this example) |
There was a problem hiding this comment.
Suggested change
| 2. Update `datasetSiteUrl` in your local broker config (packages/openactive-broker-microservice/config/local.json) to point to the local Reference Implementation's `/openactive` URL e.g. (ports are assigned randomly by .NET, so yours will differ from this example) | |
| 2. Update `datasetSiteUrl` in your [local broker config](./#local-configuration) (packages/openactive-broker-microservice/config/local.json) to point to the local Reference Implementation's `/openactive` URL e.g. (ports are assigned randomly by .NET, so yours will differ from this example) |
as it's not always obvious what local.json is from a cursory glance
There was a problem hiding this comment.
@nickevansuk What is ./#local-configuration supposed to point to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.