Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(criteria): Add TestOpportunityBookable(Non)FreeCancellable criterias #547

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

lukehesluke
Copy link
Contributor

@lukehesluke lukehesluke commented Jul 12, 2023

Rationale

Implements openactive/test-interface#18 in the Broker Microservice, which enables the implementation of #548 at a later date.

QA

Here is Broker Microservice configured against https://github.com/openactive/OpenActive.Server.NET (with a small random sample set). You can see that Broker has filtered some Opportunities into each of the new criteria:

Screenshot 2023-07-12 at 17 29 40

The results of calling the Sample Oportunities endpoint with test:testOpportunityCriteria set to TestOpportunityBookableNonFreeCancellable:

Screenshot 2023-07-12 at 17 36 59

Same for the TestOpportunityBookableFreeCancellable:

Screenshot 2023-07-12 at 17 40 15

@lukehesluke lukehesluke requested review from nickevansuk and civsiv and removed request for nickevansuk July 12, 2023 16:44
@lukehesluke lukehesluke marked this pull request as ready for review July 12, 2023 16:44
@lukehesluke lukehesluke requested a review from nickevansuk July 12, 2023 16:45
Copy link
Collaborator

@nickevansuk nickevansuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukehesluke lukehesluke merged commit a178cd8 into master Jul 13, 2023
@lukehesluke lukehesluke deleted the feature/free-non-free-cancellables branch July 13, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants