feat: Idempotency support #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehesluke
reviewed
Aug 9, 2023
| orderItemCriteriaList, | ||
| bookRecipe, | ||
| defaultFlowStageParams, | ||
| omit(bookRecipeArgs, ['prerequisite']), |
There was a problem hiding this comment.
One issue was this: Idempotent B wasn't getting the same starting args as B, which was messing up its expectations for what capacity should be asserted for after the 2nd B. This fixes that
lukehesluke
reviewed
Aug 9, 2023
| @@ -52,6 +67,7 @@ async function runB({ templateRef, accessPass, brokerRole, uuid, sellerConfig, c | |||
| brokerRole, | |||
| positionOrderIntakeFormMap, | |||
| customer, | |||
| paymentIdentifier: paymentIdentifierIfPaid, | |||
There was a problem hiding this comment.
The other issue was, as you mentioned, Nick, that paymentIdentifier was being re-generated for each B/P call. Rather than using stage input/output, I've just put it as an arg to the B / P stages, which should make it very easy to do things like test what happens if the repeated B call has a different payment identifier, if a B-after-P call has a different payment identifier, etc
nickevansuk
commented
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce commented out idempotency testing, in parallel to its support within reference implementation (openactive/OpenActive.Server.NET#100, openactive/OpenActive.Server.NET#207).
Note these tests are failing due to the following issues:
idempotentRepeatBAfterBookneeds to be wired up to work withinitialiseSimpleC1C2BookFlowpayment.identifieris currently randomly generated for each B request, which makes the request body unique.payment.identifierneeds to be consistent across the two B calls in order for the second call to trigger the idempotency logic, which is based on two identical requests.The reference implementation support for idempotency has been tested independently of the above and seems to work as expected.