feat: add broker tests for feed item transforms #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civsiv
commented
Sep 14, 2023
packages/openactive-broker-microservice/src/twoPhaseListeners/api.js
Outdated
Show resolved
Hide resolved
lukehesluke
requested changes
Sep 14, 2023
packages/openactive-broker-microservice/src/twoPhaseListeners/api.js
Outdated
Show resolved
Hide resolved
packages/openactive-broker-microservice/src/util/item-transforms.js
Outdated
Show resolved
Hide resolved
packages/openactive-broker-microservice/src/util/item-transforms.js
Outdated
Show resolved
Hide resolved
packages/openactive-broker-microservice/src/util/item-transforms.js
Outdated
Show resolved
Hide resolved
packages/openactive-broker-microservice/test/util/item-transforms-test.js
Outdated
Show resolved
Hide resolved
packages/openactive-broker-microservice/test/util/item-transforms-test.js
Outdated
Show resolved
Hide resolved
| // Assertions | ||
| expect(result).to.have.lengthOf(3); | ||
|
|
||
| expect(result[0]).to.have.property('id', '1'); |
There was a problem hiding this comment.
Sorry I know this is outside of the scope of your changes but do you happen to know why this function changes the RPDE ID to match the IFU's DATA ID? That seems like it could cause issues
There was a problem hiding this comment.
To simulate the subEvents coming from a separate feed, each item will need a unique RPDE ID right? So I think it just uses the data ID so that an RPDE ID doesn't have to made up maybe?
|
|
||
| // Assertions | ||
| expect(opportunityItem).to.deep.equal({ | ||
| id: 'https://example.com/subEvent/1', |
There was a problem hiding this comment.
same question for this function if you happen to know
…ms.js Co-authored-by: Luke Winship <[email protected]>
…ms.js Co-authored-by: Luke Winship <[email protected]>
…tive/openactive-test-suite into feature/broker-unit-tests
civsiv
commented
Sep 21, 2023
| @@ -1130,29 +1139,10 @@ async function ingestParentOpportunityPage(rpdePage, feedIdentifier, validateIte | |||
| // present in the list of new subEvents, then it has been deleted and so we remove the associated | |||
| // opportunityItem data. If a new subEvent is not present in the list of old subEvents, then we | |||
| // record its ID in the list for the next time this check is done. | |||
|
|
|||
| const oldSubEventIds = state.parentOpportunitySubEventMap.get(jsonLdId); | |||
There was a problem hiding this comment.
moved this to it's own function as it was getting my brains way
lukehesluke
approved these changes
Sep 21, 2023
| return item.data.individualFacilityUse.map((individualFacilityUse) => ({ | ||
| ...item, | ||
| kind: individualFacilityUse['@type'], | ||
| id: individualFacilityUse['@id'], |
There was a problem hiding this comment.
Given the type definition above, and line 1094 in app.js, should this be || individualFacilityUse.id ?
lukehesluke
approved these changes
Sep 21, 2023
All still working as expected
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #528
Broker working and harvesting correctly:
