Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration-tests): Make ShapeExpressions config-toggleable #588

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

lukehesluke
Copy link
Contributor

@lukehesluke lukehesluke commented Sep 20, 2023

As it is an experimental feature

Closes #587

QA

With the feature turned off

Screenshot 2023-09-20 at 18 34 20

With it turned on:

Screenshot 2023-09-20 at 18 36 45

Without including more screenshots, the same is also true for the output of the test-data-generator script (as it uses the same createTestInterfaceOpportunity(..) function)

@@ -4,6 +4,8 @@ Command line tool to generate a distribution definition of test data based on th

Test data is outputted to `./test-data/test-data.json` by default.

The data outputted by this tool can be used by a script to add sufficient test data into your [Open Booking API](https://openactive.io/open-booking-api/EditorsDraft/) implementation's database for testing when using [random mode](../README.md#userandomopportunities).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this issue to expand on this: #589

@lukehesluke lukehesluke marked this pull request as ready for review September 20, 2023 17:47
@lukehesluke lukehesluke merged commit f80a4f3 into master Feb 22, 2024
32 checks passed
@lukehesluke lukehesluke deleted the feature/toggleable-shape-expressions branch February 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Shape Expressions toggleable (default: off)
3 participants