chore: Elaborate on all TODOs #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehesluke
changed the base branch from
master
to
feature/categorise-opportunity-caches
lukehesluke
commented
Mar 25, 2024
| it('should include an orderProposalVersion, of the form {orderId}/versions/{versionUuid}', () => { | ||
| const { uuid } = defaultFlowStageParams; | ||
| expect(bookRecipe.p.getOutput().httpResponse.body).to.have.property('orderProposalVersion') | ||
| .which.matches(RegExp(`${uuid}/versions/.+`)); | ||
| }); | ||
| // TODO does validator check that full Seller details are included in the seller response? |
lukehesluke
commented
Mar 25, 2024
| @@ -26,6 +26,9 @@ function (configuration, orderItemCriteriaList, featureIsImplemented, logger, de | |||
| FlowStageUtils.describeRunAndCheckIsSuccessfulAndValid(c2, () => { | |||
| it('should include expected customer details', () => { | |||
| const apiResponseJson = c2.getStage('c2').getOutput().httpResponse.body; | |||
| if (defaultFlowStageParams.customer['@type'] !== 'Person') { | |||
There was a problem hiding this comment.
Required due to improving the customer type to also support Organization
lukehesluke
commented
Mar 25, 2024
| @@ -6,7 +6,6 @@ | |||
| * @typedef {import('./assert-opportunity-capacity').AssertOpportunityCapacityFlowStageType} AssertOpportunityCapacityFlowStageType | |||
| */ | |||
|
|
|||
| // TODO construct this class using the generic FlowStageRun (e.g. with inheritance), rather than have it be a bespoke thing | |||
There was a problem hiding this comment.
It doesn't really seem that important now that it's been a while
lukehesluke
commented
Mar 25, 2024
| @@ -399,19 +406,13 @@ function createMissingPaymentReconciliationDetailsBReq(data) { | |||
| */ | |||
| function createIncorrectReconciliationDetails(data) { | |||
| const req = createStandardPaidBReq(data); | |||
| // @ts-ignore // TODO: Figure out why req.payment isn't recognised here?! | |||
There was a problem hiding this comment.
Type was updated above to fix this issue
civsiv
approved these changes
Mar 26, 2024
Base automatically changed from
feature/categorise-opportunity-caches
to
master
March 26, 2024 17:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667
The approach I've taken: