Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unchecked undefined values in after timestamp rule #35

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: Unchecked undefined values in after timestamp rule #35

merged 1 commit into from
Sep 9, 2024

Conversation

nickevansuk
Copy link
Contributor

@nickevansuk nickevansuk commented Sep 9, 2024 •
edited
Loading

The following error illustrates that adequate checks are not in place:

Mon Sep 09 2024 13:06:51 GMT+0000 (Coordinated Universal Time) validation errored
TypeError: Cannot read property 'length' of undefined
    at AfterTimestampRule.validate (/app/node_modules/@openactive/rpde-validator/src/rules/page/after-timestamp-rule.js:97:20)
    at /app/node_modules/@openactive/rpde-validator/src/feed-checker.js:133:16
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

@nickevansuk nickevansuk enabled auto-merge (squash) September 9, 2024 13:34
@nickevansuk nickevansuk merged commit 64a53ef into master Sep 9, 2024
1 check passed
@nickevansuk nickevansuk deleted the fix/unchecked-nulls-after-timestamp branch September 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
OpenActive Infrastructure
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickevansuk