Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main #175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Main #175

wants to merge 1 commit into from

Conversation

maina-david
Copy link

update Psr18Client in client

@gehrisandro
Copy link
Collaborator

@maina-david Could you please provide some background information why this change is needed?

@maina-david
Copy link
Author

@gehrisandro HttpDiscovery is not an HTTP client itself but rather a library that helps one discover available PSR-18 client implementations in the environment. It allows the package to be more flexible and not tied to a specific HTTP client implementation like Symfony HttpClient.

@gehrisandro
Copy link
Collaborator

Thank you for clarification. This sounds like a reasonable decision.

Will check if everything is compatible with the other packages and then going to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maina-david @gehrisandro