Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more generic FS interface #1

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jsvk
Copy link
Contributor

@jsvk jsvk commented Nov 11, 2024

fs.FS is an interface *embed.FS implements, so switching to this should offer more flexibility because you can still use *embed.FS, but you can now also use your own instances of fs.FS implementations.

This is extra useful if you're creating your fs.FS at runtime, as it's not easy to create an *embed.FS at runtime.

@rookie-luochao
Copy link
Member

good job, thanks for your advice

@rookie-luochao rookie-luochao merged commit 1e0b412 into openapi-ui:main Nov 12, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants