-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Rwanda REMA data source #1089
base: main
Are you sure you want to change the base?
Conversation
Showing parameters at the top of the file and added a method to show min/max of values when doing dry runs.
A few things to do before we can push this one
I added a method that will summarize the parameters while doing the dry run, the output will look something like this
That should help with figuring out the units. |
That all sounds good. I was seeing a lot of zero values being returned which I interpreted to mean that there was no data available, which was assumption on my part. I will stop filtering for 0 values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good and its functional but lets go ahead and add docstrings. Also take a quick look through it and add a comment above any line that you think could throw an error. I want us to start anticipating errors and so this could be a good exercise to get us started.
Requested changes have been made and merge conflicts resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great but lets update it so that we dont loose all the measurements if just one of them is bad. So add a try/catch block in that foreach loop, likely the one that loops through the properties of a feature and then log out the error so we can eventually see it but dont rethrow it.
Added a try/catch block as requested |
There is an issue with time stamps being ahead with this adapter. The provided timestamps eg I have updated the code to compensate for this discrepancy and will add a note in the documentation |
Updates to our Rwanda source, uses a new data URL