Merge pull request #623 from Arnei/make-work-search-service-rewrite

Make tool work with Solr removal
opencast · Jun 25, 2024 · d59890f · d59890f
2 parents b154c7b + c8567d4
commit d59890f
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 26 deletions.
diff --git a/frontend/js/integrations/search.js b/frontend/js/integrations/search.js
@@ -87,7 +87,7 @@ define([
         data: "id=" + mediaPackageId + "&limit=1",
         dataType: "json"
     }).then(function (data) {
-        return data["search-results"].result;
+        return data.result[0];
     });
     var mediaPackage = searchResult.then(function (result) {
         return result.mediapackage;

diff --git a/.../main/java/org/opencast/annotation/impl/persistence/ExtendedAnnotationServiceJpaImpl.java b/.../main/java/org/opencast/annotation/impl/persistence/ExtendedAnnotationServiceJpaImpl.java
@@ -60,12 +60,12 @@
 import org.opencastproject.db.DBSession;
 import org.opencastproject.db.DBSessionFactory;
 import org.opencastproject.mediapackage.MediaPackage;
-import org.opencastproject.search.api.SearchQuery;
-import org.opencastproject.search.api.SearchResultItem;
 import org.opencastproject.search.api.SearchService;
 import org.opencastproject.security.api.AuthorizationService;
 import org.opencastproject.security.api.SecurityConstants;
 import org.opencastproject.security.api.SecurityService;
+import org.opencastproject.security.api.UnauthorizedException;
+import org.opencastproject.util.NotFoundException;
 import org.opencastproject.util.data.Effect;
 import org.opencastproject.util.data.Function;
 import org.opencastproject.util.data.Function0;
@@ -1271,14 +1271,11 @@ public Boolean none() {
 
   @Override
   public Option<MediaPackage> findMediaPackage(String id) {
-    return head(searchService.getByQuery(new SearchQuery().withId(id)).getItems()).map(
-            new Function<>() {
-              @Override
-              public MediaPackage apply(SearchResultItem searchResultItem) {
-                return searchResultItem.getMediaPackage();
-              }
-            }
-    );
+    try {
+      return Option.some(searchService.get(id));
+    } catch (NotFoundException | UnauthorizedException e) {
+      return Option.none();
+    }
   }
 
   @Override

diff --git a/...ckend/annotation-impl/src/test/java/org/opencast/annotation/endpoint/TestRestService.java b/...ckend/annotation-impl/src/test/java/org/opencast/annotation/endpoint/TestRestService.java
@@ -22,15 +22,14 @@
 import org.opencast.annotation.impl.persistence.ExtendedAnnotationServiceJpaImpl;
 
 import org.opencastproject.mediapackage.MediaPackage;
-import org.opencastproject.search.api.SearchQuery;
-import org.opencastproject.search.api.SearchResult;
-import org.opencastproject.search.api.SearchResultItem;
 import org.opencastproject.search.api.SearchService;
 import org.opencastproject.security.api.AuthorizationService;
 import org.opencastproject.security.api.DefaultOrganization;
 import org.opencastproject.security.api.SecurityService;
+import org.opencastproject.security.api.UnauthorizedException;
 import org.opencastproject.security.api.User;
 import org.opencastproject.security.util.SecurityUtil;
+import org.opencastproject.util.NotFoundException;
 
 import org.easymock.EasyMock;
 import org.junit.Ignore;
@@ -90,17 +89,12 @@ private static AuthorizationService getAuthorizationService() {
   private static SearchService getSearchService() {
     MediaPackage mediaPackage = EasyMock.createNiceMock(MediaPackage.class);
 
-    SearchResultItem searchResultItem = EasyMock.createNiceMock(SearchResultItem.class);
-    EasyMock.expect(searchResultItem.getMediaPackage()).andReturn(mediaPackage).anyTimes();
-    EasyMock.replay(searchResultItem);
-
-    SearchResult searchResult = EasyMock.createNiceMock(SearchResult.class);
-    EasyMock.expect(searchResult.getItems()).andReturn(new SearchResultItem[]{searchResultItem}).anyTimes();
-    EasyMock.replay(searchResult);
-
     SearchService searchService = EasyMock.createNiceMock(SearchService.class);
-    EasyMock.expect(searchService.getByQuery(EasyMock.anyObject(SearchQuery.class)))
-            .andReturn(searchResult).anyTimes();
+    try {
+      EasyMock.expect(searchService.get(EasyMock.anyObject(String.class))).andReturn(mediaPackage).anyTimes();
+    } catch (UnauthorizedException | NotFoundException e) {
+      // Do nothing. We just have to pretend to handle checked exceptions somehow to appease the compiler.
+    }
     EasyMock.replay(searchService);
     return searchService;
   }

diff --git a/pom.xml b/pom.xml
@@ -67,8 +67,8 @@
 
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
-    <opencast.build.version>14.0</opencast.build.version>
-    <opencast.deploy.version>;version="${opencast.build.version}"</opencast.deploy.version>
+    <opencast.build.version>16.0</opencast.build.version>
+    <opencast.deploy.version>;version=16.0</opencast.deploy.version>
   </properties>
 
   <build>