Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made my own PR, I hope that's okay. The original draft is here: #627
This PR contains the actual changes from @luniki + changes after review from @JulianKniephoff. The review is also to be found here: #627.
The 3 points Julian made:
renderers: ["html5", "native_hls"]
completly?: Yes, I removed it and it works. (Fixes for serverless HLS #627 (comment))The result:
So I think, it's okay to use !isFinite() instead, because it can handle one more case, but behaves the same in the other cases.
I added another small line from Marcus, where he triggers an update for the video duration. It was reported, that the time wasn't displayed correctly.