Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#191] Adding Project table and name field to pyproject.toml file #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abillama05
Copy link

Pull Request

Description

No added dependencies. This pull request addresses issue #191 where the pyproject.toml file lacked the Project table along with the associated meta data fields like name, license, and version. This should fix the issue where the pyproject build fails.

Fixes #191

How Has This Been Tested?

Ran the PyTests and received one failure out of scope of the issue associated with the "PostgresContainer".

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes
  • N/A

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@trevorgud
Copy link

For some added context, it seems this happens because of the poetry version. Broken with the release of Poetry 2.0.0+
I tested the existing toml with Poetry 1.8.5 and it works:

$ poetry --version
Poetry (version 1.8.5)
$ poetry check
All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py project must contain name
2 participants