Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding poetry to the code #87

Merged
merged 21 commits into from
Sep 27, 2024
Merged

Adding poetry to the code #87

merged 21 commits into from
Sep 27, 2024

Conversation

ADIMANV
Copy link
Contributor

@ADIMANV ADIMANV commented Sep 20, 2024

Pull Request

Description

Minor Update to the code which adds Sentry for a better error detection
Stems from the PR: openclimatefix/ocf-infrastructure#540

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
Copy link
Contributor

Thanks for this. I can see there is another error with this.
You can either

  1. pin pv site datamodel back to when it did have ClientSQL in it,
  2. update the test, to remove ClientSQL
Screenshot 2024-09-20 at 12 30 28

@peterdudfield
Copy link
Contributor

There's an out dated ClientSQL that should be removed

@ADIMANV ADIMANV merged commit 0524981 into main Sep 27, 2024
4 checks passed
@ADIMANV ADIMANV deleted the Poetry-Update branch September 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants