✨ Quartz Energy v0.1.2 → Staging #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…-csv add Sentry and log when CSV is updated
braddf
changed the title
braddf
changed the title
| @@ -1,49 +1,77 @@ | |||
| name: Node CI | |||
|
|
|||
| on: [push] | |||
| on: [pull_request] | |||
There was a problem hiding this comment.
sure we just want to run this on PRs? Does it take a long time to run, is that why you want to reduce it?
| fi | ||
| # Now only runs unit tests, Cypress tests are run in the CI pipeline on PRs | ||
| yarn test | ||
|
|
There was a problem hiding this comment.
do unit tests get run in CI too?
| maskAllText: true, | ||
| blockAllMedia: true | ||
| }) | ||
| ].filter((integration) => integration.name !== "Dedupe"); |
| import { EventHint, ErrorEvent } from "@sentry/nextjs"; | ||
|
|
||
| Sentry.init({ | ||
| dsn: "https://[email protected]/4507622592151552", |
There was a problem hiding this comment.
should these be hard coded? Or env vars?
| import { EventHint, ErrorEvent } from "@sentry/nextjs"; | ||
|
|
||
| Sentry.init({ | ||
| dsn: "https://[email protected]/4507622592151552", |
There was a problem hiding this comment.
similar point to earlier, should we make this an en var?
peterdudfield
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Much trial and error, but Cypress tests should hopefully now be working in Github Actions.
This PR includes:
Fixes #552
How Has This Been Tested?
Locally with nektos/act, and
developmentbranch on GithubChecklist: