This repository was archived by the owner on Nov 29, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 10
[wip] pydocstyle #104
Open
mfrasco
wants to merge
18
commits into
openclimatefix:main
Choose a base branch
from
mfrasco:mtf/pydocstyle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[wip] pydocstyle #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will work on documenting the functions in |
Thanks for tackling this! I think its fine all being in the same PR, I can try reviewing things as you add more. |
jacobbieker
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fantastic! Thanks so much!
Co-authored-by: Jacob Bieker <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Status
This PR is a work in progress. I have finished docstrings for the
baseline
,experiments
, anddata
modules and confirmed that these files do not generate any linter errors. I wanted to create the PR now, so that I can get early feedback from the team and also make it easier for the team to review the code in small chunks.Description
In order to standardize the code, I added and fixed docstrings according to pydocstyle, which was requested in #97
How Has This Been Tested?
This only includes changes to docstrings.
Checklist: