-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start datetime parameter to gsp/pvlive endpoint #255
Conversation
@braddf @rachel-labri-tipton Only thing I'm not sure about here is, if we're setting the usual number of days back that this endpoing can access behind an environment variable on the server side, perhaps there was the intention to keep whatever we set as N_HISTORY_DAYS as the maximum that a client-side user could ask for? This would overwrite that - so maybe I should put a block in to limit it? Or remove start datetime as an option and just change it to something like "snapshot" as a bool which just sets the startdate to last 15 minutes, preventing abuse? @devsjc, I went ahead and ran the tests on this and the route looks good. |
It might not be much better! It could just be better than target_datetime as an option as it would prevent a user trying to access the entire contents of the table with one call via a very early start_datetime_utc. |
I like the idea of this, I would perhaps put the limit on, so that the user can get the whole history. Thats what PVlive is for. Could you do this @devsjc ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add limit, so can only pull at max 3 days of data
This helps with #269 |
Adds the start_datetime_utc parameter to gsp/pvlive to enable specification of a start datetime