Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now_casting Dataset Usage and Adjust GSP Endpoints (#323) #325

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

peterdudfield
Copy link
Collaborator

  • removed nowcasting_dataset

  • [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci


Pull Request

Description

Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

roshnaeem and others added 3 commits March 11, 2024 18:07
* removed nowcasting_dataset

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* removed nowcasting_dataset

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed realted test

* Merge branch 'nowcast_dataset' of https://github.com/roshnaeem/uk-pv-national-gsp-api into nowcast_dataset

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (3aa4f6a) to head (f26d6a9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   95.40%   95.17%   -0.24%     
==========================================
  Files          20       20              
  Lines        1153     1139      -14     
==========================================
- Hits         1100     1084      -16     
- Misses         53       55       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield
Copy link
Collaborator Author

@roshnaeem The tests are still failing, can you see them?

@roshnaeem
Copy link
Contributor

@peterdudfield, I removed the relevant test from test_system.py. I am not sure why GitHub tests are failing, can you help me with them and let me know how can I fix them?

@peterdudfield
Copy link
Collaborator Author

Screenshot 2024-03-11 at 22 08 59

@roshnaeem
Copy link
Contributor

@peterdudfield, I have removed this function test_gsp_boundaries(), which the screenshots shows error in.

@peterdudfield
Copy link
Collaborator Author

@peterdudfield, I have removed this function test_gsp_boundaries(), which the screenshots shows error in.

ah sorry, could you make enough PR and we'll get rid of this

@roshnaeem
Copy link
Contributor

@peterdudfield, another PR?

@peterdudfield
Copy link
Collaborator Author

@peterdudfield, another PR?

sorry my mistake, looks like it is now working

@peterdudfield peterdudfield merged commit 68eaad1 into main Mar 12, 2024
3 of 4 checks passed
@peterdudfield peterdudfield deleted the external-pr branch March 12, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants