-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove now_casting Dataset Usage and Adjust GSP Endpoints (#323) #325
Conversation
* removed nowcasting_dataset * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* removed nowcasting_dataset * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removed realted test * Merge branch 'nowcast_dataset' of https://github.com/roshnaeem/uk-pv-national-gsp-api into nowcast_dataset --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 95.40% 95.17% -0.24%
==========================================
Files 20 20
Lines 1153 1139 -14
==========================================
- Hits 1100 1084 -16
- Misses 53 55 +2 ☔ View full report in Codecov by Sentry. |
@roshnaeem The tests are still failing, can you see them? |
@peterdudfield, I removed the relevant test from test_system.py. I am not sure why GitHub tests are failing, can you help me with them and let me know how can I fix them? |
@peterdudfield, I have removed this function |
ah sorry, could you make enough PR and we'll get rid of this |
@peterdudfield, another PR? |
sorry my mistake, looks like it is now working |
removed nowcasting_dataset
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Pull Request
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: