Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

327 update dm #329

Merged
merged 5 commits into from
Mar 13, 2024
Merged

327 update dm #329

merged 5 commits into from
Mar 13, 2024

Conversation

peterdudfield
Copy link
Collaborator

Pull Request

Description

role back pydantic model changes
1.5.44 force the UI to log out - very odd behaviour

How Has This Been Tested?

CI tests?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (68eaad1) to head (7c6b9d0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          20       20           
  Lines        1139     1139           
=======================================
  Hits         1084     1084           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield merged commit adb9f1a into main Mar 13, 2024
6 checks passed
@peterdudfield peterdudfield deleted the 327-update-dm branch March 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant