Enable Python 3.13 and make tests more resilient to lacking cplex/gurobi wheels #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdiener
force-pushed
the
feature/additional_solvers
branch
from
29b800a to
5efeb03
Compare
Midnighter
reviewed
Dec 8, 2024
Midnighter
approved these changes
Dec 8, 2024
Midnighter
reviewed
Dec 8, 2024
| @@ -11,7 +11,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-13, windows-latest] | |||
| python-version: ["3.8", "3.11"] | |||
| python-version: ["3.9", "3.11", "3.13"] | |||
There was a problem hiding this comment.
Lowest and highest version is good enough in my opinion.
Suggested change
| python-version: ["3.9", "3.11", "3.13"] | |
| python-version: ["3.9", "3.13"] |
There was a problem hiding this comment.
I had 3.11 because it is the latest version that supports all solvers. But it would work with 3.9 but 3.11 pulls in much newer dependencies and I thought it might be good to test this.
There was a problem hiding this comment.
Okay, that makes sense :slight_smile:
Co-authored-by: Moritz E. Beber <[email protected]>
Midnighter
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CI/CD to newer Python versions and limits the CPLEX, Gurobi, and MIP tests to those python versions that support them.