Parse_set / Parse_choice shrinking #1440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See PR #1419.)
Parse_set::num_pc
in unused space inParse_set
to save repeated counting inlist_random_links()
.In principle, it is possible to calculate and cache
num_pc
indo_count()
and then eliminateParse_coice::next
and simplify link extraction (no need to scan a list). There is a missing infrastructure for that indo_coutn()
but I may add it (to speed up parsing with nulls). In any case, the overhead of thisnum_pc
caching is unclear.