Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the use of cost cutoffs in the English dict. #1455

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

linas
Copy link
Member

@linas linas commented Feb 25, 2023

Per discussions in #1453

@linas linas merged commit 9c1da19 into opencog:master Feb 25, 2023
@linas linas deleted the disable-cost-cutoff branch February 25, 2023 01:37
@ampli
Copy link
Member

ampli commented Feb 25, 2023

For some reason, this PR causes the ru parsing not to work at all.

@linas linas mentioned this pull request Feb 25, 2023
@ampli
Copy link
Member

ampli commented Feb 25, 2023

It seems that now ru needs at least cost-max=6 to work. But with any cost-max it doesn't work as intended, and these sentences are now parsed incorrectly:

<  *это тестами
<  *это тестом
<  *это тестями
<  прежде всего , требуется определить само понятие жизни .
<  скорее всего , дракон несет свою обычную стражу .

@linas
Copy link
Member Author

linas commented Feb 25, 2023

If russian does not work, then it is not due to this PR, but to #1456 ... fixed in #1458

linas added a commit that referenced this pull request Mar 5, 2023
The change in commit d04a337 broke the unit test.
aka pull req #1455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants