-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update autogen.sh #1531
Merged
Merged
Update autogen.sh #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is handled by autoreconf. The autoconf manual says: "aclocal is expected to disappear. This feature really should not be offered by Automake." And then it says "... never call aclocal yourself." Also remove the special Cygwin setting of '-I m4'.
On MacOS, autoreconf is supposed to call glibtoolize if exists (to be validated later).
It is invoked by autoreconf.
It is invoked by autoreconf,
The code to keep the old configure script was taken from Subversion's autogen.sh, but somehow only the first half of the code was used, making it pointless. Add the second half of the code that removes config.cache if the configure script has been changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the calls to
aclocal
,libtoolize
,autoconf
, andautomake
, which became unneeded after the recent addition ofautoreconf
toautogen.sh
(PR #1516, see also issue #1492).On the same occasion:
perl
withsed
.But is this check needed anymore since version 1.4 is ancient?
config.cache
if needed.The "original"
autogen.sh
contains only the first half of the code to removeconfig.cache
whenconfigure
changes.Add the second half of the code that removes
config.cache
if needed.The Autoconf system is careful to prefix its messages with the program name. Do so for the messages here, too, so their source is clear.
Stale or corrupted caches may cause mysterious problems. Add an option to start from a clean state.
Insist that
autogen.sh
is invoked from the top-level directory.I checked it on MacOS (old system - 11.6.2), Cygwin, MinGW64, and Linux.
On MinGW64,
configure
doesn't have an x bit. Instead of changingautogen.sh
, I changedREADME-MinGW64.md
.