Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autogen.sh #1531

Merged
merged 17 commits into from
May 20, 2024
Merged

Update autogen.sh #1531

merged 17 commits into from
May 20, 2024

Conversation

ampli
Copy link
Member

@ampli ampli commented May 19, 2024

Remove the calls to aclocal, libtoolize, autoconf, and automake, which became unneeded after the recent addition of autoreconf to autogen.sh (PR #1516, see also issue #1492).

On the same occasion:

  • Replace perl with sed.
    But is this check needed anymore since version 1.4 is ancient?
  • Remove config.cache if needed.
    The "original" autogen.sh contains only the first half of the code to remove config.cache when configure changes.
    Add the second half of the code that removes config.cache if needed.
  • Prefix messages with the script name.
    The Autoconf system is careful to prefix its messages with the program name. Do so for the messages here, too, so their source is clear.
  • Add --clean.
    Stale or corrupted caches may cause mysterious problems. Add an option to start from a clean state.
  • Add --help.
  • Add invocation directory consistency check.
    Insist that autogen.sh is invoked from the top-level directory.

I checked it on MacOS (old system - 11.6.2), Cygwin, MinGW64, and Linux.
On MinGW64, configure doesn't have an x bit. Instead of changing autogen.sh, I changed README-MinGW64.md.

ampli added 17 commits May 18, 2024 15:58
It is handled by autoreconf.

The autoconf manual says:
"aclocal is expected to disappear. This feature really should not be
offered by Automake."
And then it says "... never call aclocal yourself."

Also remove the special Cygwin setting of '-I m4'.
On MacOS, autoreconf is supposed to call glibtoolize if exists (to be
validated later).
It is invoked by autoreconf.
It is invoked by autoreconf,
The code to keep the old configure script was taken from Subversion's
autogen.sh, but somehow only the first half of the code was used, making
it pointless.

Add the second half of the code that removes config.cache if the
configure script has been changed.
@linas linas merged commit ae590f0 into opencog:master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants