[TAM]: Remove mandatory flag on the attribute TAM DSCP #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pterosaur
changed the title
|
/azpw run |
rck-innovium
approved these changes
Jan 24, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
remove_mandatory_tam_dscp
branch
from
68ddcdb to
65ef6d5
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2133 in repo opencomputeproject/SAI |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2133 in repo opencomputeproject/SAI |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jan 27, 2025
|
makes sense! Thanks Ze! |
|
@kcudnik Could you please help to merge this PR? |
|
was this already discussed on SAI community meeting and approved ? |
Not yet, but this is proposed by a vendor and we both think it's reasonable and straightforward. Because the original API design was already adapted the GENetlink few years ago, and it is obvious that GENetlink doesn't have DSCP field. Right now, vendors need to implement this scenario and this issue is revealed. |
|
agree, and this change is backward compatible, but i think every change to api should be discussed on team meeting, is this time sensitive to merge this soon ? |
marian-pritsak
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some transport protocols, such as GENetlink, the attribute DSCP is meaningless.
So, remove the mandatory flag on the attribute TAM DSCP and use the default value 0 to indicate this protocol doesn't support the field DSCP.