Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments for few macsec sa stats to make clear it is cummulative #2136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

judyjoseph
Copy link

Update the comments of few SA stats viz. SAI_MACSEC_SA_STAT_IN_PKTS_INVALID, SAI_MACSEC_SA_STAT_IN_PKTS_NOT_USING_SA, SAI_MACSEC_SA_STAT_IN_PKTS_UNUSED_SA, SAI_MACSEC_SA_STAT_IN_PKTS_OK, SAI_MAC to make it clear that these stats are cumulative as other attributes.

@judyjoseph judyjoseph requested a review from kcudnik January 27, 2025 19:16
@judyjoseph judyjoseph force-pushed the update_macsec_attr_comments branch from 33decea to f097169 Compare January 28, 2025 17:06
@tjchadaga
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Feb 2, 2025

WARNING: Word 'InPktsInvalid' is misspelled saimacsec.h 968: * statistics InPktsInvalid.
WARNING: Word 'InPktsOk' is misspelled saimacsec.h 996: * statistics InPktsOk.
Processing sai_8h.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants