OTG Test Update - RT 6.1 - LLDP neighbor verification change

[octpetre]

This changes is required in order to correctly match the status of an LLDP neighbor based on it oc telemetry not configuration.
Resolves #587

[OpenConfigBot]

Pull Request Functional Test Report for #1887 / 4d430e0

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-6.1: Core LLDP TLV Population
Cisco 8000E		RT-6.1: Core LLDP TLV Population
Cisco XRd		RT-6.1: Core LLDP TLV Population
Juniper ncPTX		RT-6.1: Core LLDP TLV Population
Nokia SR Linux		RT-6.1: Core LLDP TLV Population
Openconfig Lemming		RT-6.1: Core LLDP TLV Population

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-6.1: Core LLDP TLV Population
Cisco 8808		RT-6.1: Core LLDP TLV Population
Juniper PTX10008		RT-6.1: Core LLDP TLV Population
Nokia 7250 IXR-10e		RT-6.1: Core LLDP TLV Population

Help

[coveralls]

Pull Request Test Coverage Report for Build 12356678562

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 55.268%

---

Totals
Change from base Build 12343488153:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

---

💛 - Coveralls

[jasdeep-hundal]

The README suggests we need to change the structure of the test overall.

Reading it closely, it seems to imply that we need to specifically test with LLDP enabled before disabling it, and that we do not disable LLDP at the interface level for the 2nd test.

I am happy with that in a follow-up patch though, let's leave the re-opened bug open in that case though.

[alokmtri-g]

TestLLDPEnabled is failing in neighbor state verification:

PR1887.log

third_party/openconfig/featureprofiles/feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go:288: Telemetry for Node port neighbor at /lldp/interfaces/interface[name=et-0/0/1]/neighbors/neighbor[id=02:00:22:01:01:01-00:00:00:00:00:01]:

     {
       "openconfig-lldp:id": "02:00:22:01:01:01-00:00:00:00:00:01",
       "openconfig-lldp:state": {
         "age": "24",
         "chassis-id": "02:00:22:01:01:01",
         "chassis-id-type": "MAC_ADDRESS",
         "id": "02:00:22:01:01:01-00:00:00:00:00:01",
         "last-update": "24",
         "management-address": "",
         "management-address-type": "",
         "port-description": "",
         "port-id": "00:00:00:00:00:01",
         "port-id-type": "MAC_ADDRESS",
         "system-description": "Lldp emulation on Ixia-IxHw",
         "system-name": "ixia-otg",
         "ttl": 120
       }
     }
 **third_party/openconfig/featureprofiles/feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go:298: /state/port-id: got &00:00:00:00:00:01, want &6/3
 third_party/openconfig/featureprofiles/feature/lldp/otg_tests/core_lldp_tlv_population_test/core_lldp_tlv_population_test.go:298: /state/port-id-type: got MAC_ADDRESS, want INTERFACE_NAME**