RT-1.51: BGP multipath ECMP and RT-1.52 bgp_multipath_wecmp_test.go : Added deviation #2547

cprabha · 2024-01-13T02:08:54Z

Hi,

bgp_multipath_ecmp_test.go
1. I have updated with deviation for max paths.
2. Current script is with one source and one destination. I have updated the destination with all advertised routes and added multiple source to verify load balance.

bgp_multipath_wecmp_test.go

bgp4PeerRoute.ExtendedCommunities().Add() is missing in configure OTG, it will lead to panic failure.
In traffic flow creation, port1 used as rx port, fixed this to start setting rx from port2.

Thanks
Prabha

OpenConfigBot · 2024-01-13T02:09:09Z

Pull Request Functional Test Report for #2547 / `66e4bb4`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Cisco 8000E		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Cisco XRd		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Juniper ncPTX		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Nokia SR Linux		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Openconfig Lemming		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Cisco 8808		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Juniper PTX10008		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community
Nokia 7250 IXR-10e		RT-1.51: BGP multipath ECMP RT-1.52: BGP multipath UCMP support with Link Bandwidth Community

Help

coveralls · 2024-01-19T18:21:17Z

Pull Request Test Coverage Report for Build 9378621909

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9378378586:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

sezhang2

New deviation bool bgp_max_multipath_paths_unsupported is added for Juniper and tracked by b/319301559

ram-mac

Can we fix the Readme. Have run the tests Rt-1.51 and 1.52 and it passes. So once we have the readme passed we can merge it.

cprabha · 2024-05-15T19:24:52Z

Can we fix the Readme. Have run the tests Rt-1.51 and 1.52 and it passes. So once we have the readme passed we can merge it.

Sure, will update README.

…ffic flows for loadbalancing

ram-mac

Validated; Looks good now

… Added deviation (openconfig#2547) * updated with deviation * Resovled conflicts * Resovled conflicts * Resolving conflicts * Resolving conflicts * updated with deviation * Added deviation to script * Added deviation to wecmp script * Resolving merge conflicts * Resolving conflict * Resolvng coflicts * resolving conflicts * Resolving conflicts * updated version * Resolving conflicts * Resolving conflicts * Resolved conflicts * updated README * updated README * Resolving conflicts * Resolving conflicts * Resolving conflicts * Resolving conflicts * Added deviation for multipath config at peer level * Added deviations to configure multipath at peer level and updated traffic flows for loadbalancing * Resolving conflicts * Resolving conflicts * resolving conflicts --------- Co-authored-by: Arul Kumar Sekar <[email protected]> Co-authored-by: KandukuriSudheer <[email protected]> Co-authored-by: Ram <[email protected]>

updated with deviation

8ec47da

cprabha requested review from a team as code owners January 13, 2024 02:08

cprabha requested review from a team and jasdeep-hundal January 13, 2024 02:08

cprabha added the juniper-pr label Jan 13, 2024

arulkumarsekar and others added 3 commits January 18, 2024 12:32

Merge branch 'main' into bgpEcmp

c864ec5

Merge branch 'main' into bgpEcmp

61cc7b0

Resovled conflicts

5fa3584

cprabha added 2 commits January 19, 2024 10:30

Resovled conflicts

391a824

Merge branch 'main' into bgpEcmp

39b1cbb

sezhang2 previously approved these changes Jan 25, 2024

View reviewed changes

arulkumarsekar and others added 2 commits January 25, 2024 16:58

Merge branch 'main' into bgpEcmp

7e32b27

Merge branch 'main' into bgpEcmp

1b17368

cprabha dismissed sezhang2’s stale review via 1b17368 February 8, 2024 21:25

cprabha added 4 commits February 8, 2024 13:29

Resolving conflicts

f922bc6

Merge branch 'main' into bgpEcmp

7a82f4e

Resolving conflicts

9c34cc1

updated with deviation

e0de796

cprabha requested a review from sezhang2 February 26, 2024 19:41

cprabha added 5 commits March 8, 2024 12:25

Added deviation to script

2d56bbd

Merge branch 'main' into bgpEcmp

6acc2ec

Added deviation to wecmp script

9ef24d0

Merge branch 'main' into bgpEcmp

493e9d0

Merge branch 'main' into bgpEcmp

b767e2c

ram-mac assigned ram-mac and Swetha-haridasula Mar 15, 2024

Resolving merge conflicts

05801ed

ram-mac self-requested a review May 3, 2024 09:18

ram-mac assigned ram-mac and unassigned Swetha-haridasula May 3, 2024

cprabha added 2 commits May 8, 2024 15:21

Merge branch 'main' into bgpEcmp

5492831

Resolved conflicts

1c9e079

ram-mac reviewed May 15, 2024

View reviewed changes

cprabha and others added 14 commits May 16, 2024 14:34

Merge branch 'main' into bgpEcmp

fdb8d10

updated README

9e0c5e7

updated README

668c991

Resolving conflicts

7be3dc8

Resolving conflicts

5768a37

Resolving conflicts

2eb8304

Resolving conflicts

97e059f

Added deviation for multipath config at peer level

a543eef

Added deviations to configure multipath at peer level and updated tra…

3cfab63

…ffic flows for loadbalancing

Merge branch 'main' into bgpEcmp

66e4bb4

Merge branch 'main' into bgpEcmp

f833841

Resolving conflicts

d2a6ec2

Merge branch 'main' into bgpEcmp

fb39123

Resolving conflicts

d719f85

cprabha requested a review from ram-mac May 31, 2024 17:44

cprabha and others added 3 commits June 4, 2024 09:10

Merge branch 'main' into bgpEcmp

371dd78

resolving conflicts

0bbc587

Merge branch 'main' into bgpEcmp

2a0cda2

ram-mac approved these changes Jun 5, 2024

View reviewed changes

ram-mac merged commit b549dad into openconfig:main Jun 5, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RT-1.51: BGP multipath ECMP and RT-1.52 bgp_multipath_wecmp_test.go : Added deviation #2547

RT-1.51: BGP multipath ECMP and RT-1.52 bgp_multipath_wecmp_test.go : Added deviation #2547

cprabha commented Jan 13, 2024 •

edited

Loading

OpenConfigBot commented Jan 13, 2024 •

edited

Loading

coveralls commented Jan 19, 2024 •

edited

Loading

sezhang2 left a comment

ram-mac left a comment

cprabha commented May 15, 2024

ram-mac left a comment

RT-1.51: BGP multipath ECMP and RT-1.52 bgp_multipath_wecmp_test.go : Added deviation #2547

RT-1.51: BGP multipath ECMP and RT-1.52 bgp_multipath_wecmp_test.go : Added deviation #2547

Conversation

cprabha commented Jan 13, 2024 • edited Loading

OpenConfigBot commented Jan 13, 2024 • edited Loading

Pull Request Functional Test Report for #2547 / 66e4bb4

Virtual Devices

Hardware Devices

coveralls commented Jan 19, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9378621909

Details

💛 - Coveralls

sezhang2 left a comment

Choose a reason for hiding this comment

ram-mac left a comment

Choose a reason for hiding this comment

cprabha commented May 15, 2024

ram-mac left a comment

Choose a reason for hiding this comment

cprabha commented Jan 13, 2024 •

edited

Loading

OpenConfigBot commented Jan 13, 2024 •

edited

Loading

Pull Request Functional Test Report for #2547 / `66e4bb4`

coveralls commented Jan 19, 2024 •

edited

Loading