System-1: added p4rt capabilities deviation and fixed gnmi call #2605

kjahed · 2024-01-31T15:05:26Z

This PR modifies System-1:

In TestP4RTClient: add P4RT capabilities unsupported deviation for CISCO and use a Read request instead.
In TestGNMIClient: make a get request for a well-supported leaf.

OpenConfigBot · 2024-01-31T15:05:41Z

Pull Request Functional Test Report for #2605 / `95218b1`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		System-1: System testing
Cisco 8000E		System-1: System testing
Cisco XRd		System-1: System testing
Juniper ncPTX		System-1: System testing
Nokia SR Linux		System-1: System testing
Openconfig Lemming		System-1: System testing

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		System-1: System testing
Cisco 8808		System-1: System testing
Juniper PTX10008		System-1: System testing
Nokia 7250 IXR-10e		System-1: System testing

Help

coveralls · 2024-01-31T15:11:35Z

Pull Request Test Coverage Report for Build 12434791205

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals
Change from base Build 12419317171:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

💛 - Coveralls

feature/system/tests/system_base_test/g_protocol_test.go

ram-mac · 2024-12-16T12:23:35Z

@kjahed , please resolve the conflicts and other comment

kjahed · 2024-12-16T19:44:13Z

@kjahed , please resolve the conflicts and other comment

@ram-mac done.

proto/metadata.proto

feature/system/tests/system_base_test/g_protocol_test.go

Swetha-haridasula · 2024-12-17T09:40:27Z

feature/system/tests/system_base_test/g_protocol_test.go

+		req = &gpb.GetRequest{
+			Path: []*gpb.Path{{
+				Elem: []*gpb.PathElem{
+					{Name: "system"}, {Name: "state"}, {Name: "hostname"}}},


can we add a check for type config and operational as well here if it is supported

kindly also add check for type config and operational here as per definition 'https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#331-the-getrequest-message'

@kjahed - Awaiting your response on this one; We need to know if in default state we have support for "Config", "State" and "Operational".
You have responded for "Config" and "State", what about "Operational".
Can you close on this comment?

ram-mac · 2024-12-18T06:47:02Z

@kjahed - Please address the comments from Swetha where we need to create bugs for the deviations and also resolve the conflicts. I have validated the test and it is now passing; Once the comments are taken care we can approve the PR.

kjahed · 2024-12-18T21:58:01Z

@kjahed - Please address the comments from Swetha where we need to create bugs for the deviations and also resolve the conflicts. I have validated the test and it is now passing; Once the comments are taken care we can approve the PR.

@ram-mac I noticed #3416 adds a deviation that we can re-use since we do support get on root for config type. This makes one of the deviation added in this PR redundant. We still need the p4rt_capabilities_unsupported deviation though. What do you suggest we do? should we wait for #3416 to be merged and update accordingly?

ram-mac · 2024-12-19T04:28:22Z

@kjahed - Please address the comments from Swetha where we need to create bugs for the deviations and also resolve the conflicts. I have validated the test and it is now passing; Once the comments are taken care we can approve the PR.

@ram-mac I noticed #3416 adds a deviation that we can re-use since we do support get on root for config type. This makes one of the deviation added in this PR redundant. We still need the p4rt_capabilities_unsupported deviation though. What do you suggest we do? should we wait for #3416 to be merged and update accordingly?

@kjahed - Lets retain deviations in this PR. The PR3416 will be handled separately. As suggested above

please create 2 bugs one for the p4rt_capablities_unsupported deviation and another for get on root gnmi_get_on_root_unsupported and update the metadata.proto with these bugs. Need to track these deviations
Also please specify if we support type config

Lets address all these comments ASAP.

kjahed · 2024-12-20T16:20:45Z

@kjahed - Please address the comments from Swetha where we need to create bugs for the deviations and also resolve the conflicts. I have validated the test and it is now passing; Once the comments are taken care we can approve the PR.

@ram-mac I noticed #3416 adds a deviation that we can re-use since we do support get on root for config type. This makes one of the deviation added in this PR redundant. We still need the p4rt_capabilities_unsupported deviation though. What do you suggest we do? should we wait for #3416 to be merged and update accordingly?

@kjahed - Lets retain deviations in this PR. The PR3416 will be handled separately. As suggested above

please create 2 bugs one for the p4rt_capablities_unsupported deviation and another for get on root gnmi_get_on_root_unsupported and update the metadata.proto with these bugs. Need to track these deviations

Also please specify if we support type config

Lets address all these comments ASAP.

Done. As I mentioned, we do support get on root for config, which is why I suggested we use the deviation in 3416 instead.

ram-mac

Changes looks good

Swetha-haridasula · 2024-12-24T06:13:31Z

@kjahed can we add a check for type config and operational as well here along with type state

ram-mac · 2024-12-24T06:22:16Z

@kjahed - Please help close the final comment and also resolve the conflicts; So we could merge it.

Swetha-haridasula · 2024-12-26T01:41:09Z

Here when GNMIGetOnRootUnsupported deviation is added please add 3 subtests under it

Get using type=state
get using type=config
Get using type=operational
If any of the above types are again not supported you may add a deviation for them with workaround.

added p4rt capabilities deviation and fixed gnmi call

b731918

kjahed requested review from a team as code owners January 31, 2024 15:05

kjahed added the cisco-pr label Jan 31, 2024

kjahed added 2 commits May 7, 2024 19:34

Merge remote-tracking branch 'public/main' into kjahed/oc-1.1

adb5665

gofmt

4410281

self-maurya self-requested a review October 8, 2024 07:02

self-maurya requested review from Swetha-haridasula and removed request for a team and self-maurya October 16, 2024 15:29

kjahed added 2 commits November 27, 2024 16:40

Merge remote-tracking branch 'public/main' into kjahed/oc-1.1

1f4fab9

fix readme

ec01f8a

ram-mac self-assigned this Nov 29, 2024

LimeHat suggested changes Dec 3, 2024

View reviewed changes

feature/system/tests/system_base_test/g_protocol_test.go Outdated Show resolved Hide resolved

dplore reviewed Dec 3, 2024

View reviewed changes

feature/system/tests/system_base_test/g_protocol_test.go Show resolved Hide resolved

kjahed added 2 commits December 9, 2024 11:20

Merge remote-tracking branch 'public/main' into kjahed/oc-1.1

8e1fa97

add gnmi_get_on_root_unsupported for cisco

a72e351

ram-mac assigned kjahed and unassigned ram-mac Dec 16, 2024

Merge remote-tracking branch 'public/main' into kjahed/oc-1.1

e65119a

Swetha-haridasula assigned Swetha-haridasula and unassigned kjahed Dec 17, 2024

Swetha-haridasula reviewed Dec 17, 2024

View reviewed changes

proto/metadata.proto Show resolved Hide resolved

Swetha-haridasula reviewed Dec 17, 2024

View reviewed changes

feature/system/tests/system_base_test/g_protocol_test.go Show resolved Hide resolved

Swetha-haridasula reviewed Dec 17, 2024

View reviewed changes

ram-mac self-assigned this Dec 18, 2024

kjahed added 2 commits December 20, 2024 11:15

Merge remote-tracking branch 'public/main' into kjahed/oc-1.1

2529f75

added bug ids

95218b1

kjahed force-pushed the kjahed/oc-1.1 branch from ec8e139 to 95218b1 Compare December 20, 2024 16:18

kjahed requested a review from a team December 20, 2024 16:18

ram-mac approved these changes Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

System-1: added p4rt capabilities deviation and fixed gnmi call #2605

System-1: added p4rt capabilities deviation and fixed gnmi call #2605

kjahed commented Jan 31, 2024

OpenConfigBot commented Jan 31, 2024 •

edited

Loading

coveralls commented Jan 31, 2024 •

edited

Loading

ram-mac commented Dec 16, 2024

kjahed commented Dec 16, 2024

Swetha-haridasula Dec 17, 2024

Swetha-haridasula Dec 24, 2024

ram-mac Dec 24, 2024

ram-mac commented Dec 18, 2024

kjahed commented Dec 18, 2024

ram-mac commented Dec 19, 2024

kjahed commented Dec 20, 2024

ram-mac left a comment

Swetha-haridasula commented Dec 24, 2024

ram-mac commented Dec 24, 2024

Swetha-haridasula commented Dec 26, 2024

System-1: added p4rt capabilities deviation and fixed gnmi call #2605

Are you sure you want to change the base?

System-1: added p4rt capabilities deviation and fixed gnmi call #2605

Conversation

kjahed commented Jan 31, 2024

OpenConfigBot commented Jan 31, 2024 • edited Loading

Pull Request Functional Test Report for #2605 / 95218b1

Virtual Devices

Hardware Devices

coveralls commented Jan 31, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12434791205

Details

💛 - Coveralls

ram-mac commented Dec 16, 2024

kjahed commented Dec 16, 2024

Swetha-haridasula Dec 17, 2024

Choose a reason for hiding this comment

Swetha-haridasula Dec 24, 2024

Choose a reason for hiding this comment

ram-mac Dec 24, 2024

Choose a reason for hiding this comment

ram-mac commented Dec 18, 2024

kjahed commented Dec 18, 2024

ram-mac commented Dec 19, 2024

kjahed commented Dec 20, 2024

ram-mac left a comment

Choose a reason for hiding this comment

Swetha-haridasula commented Dec 24, 2024

ram-mac commented Dec 24, 2024

Swetha-haridasula commented Dec 26, 2024

OpenConfigBot commented Jan 31, 2024 •

edited

Loading

Pull Request Functional Test Report for #2605 / `95218b1`

coveralls commented Jan 31, 2024 •

edited

Loading