RT-1.32 : actions_MED_LocPref_prepend_flow_control_test.go #2767

cprabha · 2024-03-06T04:00:04Z

Hi,

Deletion of policy is always needed before configuring new policy.
Added deviations , vendor specific

Thanks,
Prabha

OpenConfigBot · 2024-03-06T04:00:21Z

Pull Request Functional Test Report for #2767 / `6229ea0`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Cisco 8000E		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Cisco XRd		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Juniper ncPTX		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Nokia SR Linux		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Openconfig Lemming		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Cisco 8808		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Juniper PTX10008		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Nokia 7250 IXR-10e		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Help

coveralls · 2024-03-06T04:03:17Z

Pull Request Test Coverage Report for Build 12440249480

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals
Change from base Build 12422942759:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

💛 - Coveralls

…into RT-1.32

dplore · 2024-12-14T04:30:54Z

/fptest virtual

dplore · 2024-12-17T01:04:03Z

@cprabha I see this test is failing on cptx. Can you share your test results, and the version of the OS you are using to test?

Here are the test results I see:
https://gist.github.com/dplore/bde064d085d659b76fc448c06787712a

dut.os_version -> 22.3X80-D45.19-EVO

…into RT-1.32

cprabha · 2024-12-17T20:34:27Z

@cprabha I see this test is failing on cptx. Can you share your test results, and the version of the OS you are using to test?

Here are the test results I see: https://gist.github.com/dplore/bde064d085d659b76fc448c06787712a

dut.os_version -> 22.3X80-D45.19-EVO

@dplore, Please could you re run now . I have verified on both platforms it works now. Issue was with ixia not liking advertised net, modified prefix length it started working.

dplore · 2024-12-17T23:05:20Z

/fptest virtual

dplore · 2024-12-20T18:04:44Z

/fptest virtual

internal/deviations/deviations.go

proto/metadata.proto

feature/bgp/policybase/otg_tests/actions_med_localpref_prepend_flow_control/metadata.textproto

.../actions_med_localpref_prepend_flow_control/actions_MED_LocPref_prepend_flow_control_test.go

Co-authored-by: Darren Loher <[email protected]>

dplore

Thanks for these changes! They will help with readability of the code.

one last minor nit asked for.

.../actions_med_localpref_prepend_flow_control/actions_MED_LocPref_prepend_flow_control_test.go

dplore · 2024-12-20T23:45:20Z

@self-maurya @rohit-rp this is ready for your final review/approval, necesary to merge this PR.

…g#2767) * updated RT-1.32 * resolving conflicts * Fixing go static error * Resolving conflicts * Resolving conflicts * Changed folder name as per latest git commit * updating with git copy of README * Resolving conflicts * Resolving conflicts * updated * updating deviations * resolving conflicts * Resvoling conflicts * resolving conflicts * Added verification for setmedincrease policy * updated verification * Resolving conflicts * resoving conflicts * Resolving conflicts * Resolving commit * resolving conflicts * REsolving conflicts * removed space * updated with native cli * resolving conflicts * Update deviations.go * Update deviations.go * Update deviations.go * Update metadata.pb.go * Update metadata.pb.go * Update actions_MED_LocPref_prepend_flow_control_test.go * Update metadata.textproto * Update metadata.textproto * Update deviations.go * Update metadata.proto * Update metadata.pb.go * regenerated proto stubs * REsolving conflicts * Resolving conflicts * Update internal/deviations/deviations.go Co-authored-by: Darren Loher <[email protected]> * updating comments * REsolving erros * updating comment * updating review comment --------- Co-authored-by: Swetha-haridasula <[email protected]> Co-authored-by: Nisha Sadhasivam <[email protected]> Co-authored-by: Pramod Maurya <[email protected]> Co-authored-by: Darren Loher <[email protected]>

updated RT-1.32

215b77b

cprabha requested review from a team as code owners March 6, 2024 04:00

cprabha requested a review from jasdeep-hundal March 6, 2024 04:00

Merge branch 'main' into RT-1.32

a35bce0

cprabha added the juniper-pr label Mar 6, 2024

cprabha added 11 commits March 18, 2024 01:03

Merge branch 'main' into RT-1.32

c545a3f

resolving conflicts

17cc615

Merge branch 'main' into RT-1.32

4c686bb

Fixing go static error

80e528e

Merge branch 'RT-1.32' of https://github.com/cprabha/featureprofiles …

01a28b4

…into RT-1.32

Merge branch 'main' into RT-1.32

b6023a1

Resolving conflicts

b3cc76b

Merge branch 'main' into RT-1.32

e10b88e

Resolving conflicts

a15fbbd

Changed folder name as per latest git commit

3f1340b

updating with git copy of README

ff48324

ram-mac self-requested a review April 22, 2024 05:15

Merge branch 'main' into RT-1.32

e3cfa2a

cprabha marked this pull request as draft April 22, 2024 22:12

cprabha added 3 commits April 23, 2024 17:31

Resolving conflicts

2b9c1dd

Resolving conflicts

d04d22e

updated

e6af919

cprabha marked this pull request as ready for review August 13, 2024 15:10

cprabha added 3 commits August 13, 2024 20:44

Merge branch 'main' into RT-1.32

90d2665

updating deviations

afb9a30

Merge branch 'RT-1.32' of https://github.com/cprabha/featureprofiles …

e041fa1

…into RT-1.32

cprabha added 3 commits December 17, 2024 12:25

REsolving conflicts

ebd343c

Merge branch 'RT-1.32' of https://github.com/cprabha/featureprofiles …

45bc6ad

…into RT-1.32

Merge branch 'main' into RT-1.32

f66d690

cprabha dismissed nsadhasivam’s stale review via f66d690 December 17, 2024 20:29

cprabha added 2 commits December 17, 2024 12:29

Merge branch 'RT-1.32' of https://github.com/cprabha/featureprofiles …

f668978

…into RT-1.32

Resolving conflicts

cc21b8d

cprabha requested a review from nsadhasivam December 17, 2024 20:34

Merge branch 'main' into RT-1.32

872ed54

dplore requested a review from a team December 17, 2024 23:05

Merge branch 'main' into RT-1.32

0ec3805

dplore requested changes Dec 20, 2024

View reviewed changes

cprabha and others added 5 commits December 20, 2024 11:13

Update internal/deviations/deviations.go

b1bfd3a

Co-authored-by: Darren Loher <[email protected]>

updating comments

84a2720

updating review comments

fecb219

REsolving erros

363140f

updating comment

5e8c9ac

cprabha requested a review from dplore December 20, 2024 21:10

dplore reviewed Dec 20, 2024

View reviewed changes

.../actions_med_localpref_prepend_flow_control/actions_MED_LocPref_prepend_flow_control_test.go Outdated Show resolved Hide resolved

updating review comment

6229ea0

cprabha requested a review from dplore December 21, 2024 00:12

dplore approved these changes Dec 21, 2024

View reviewed changes

self-maurya approved these changes Dec 23, 2024

View reviewed changes

self-maurya merged commit 6c2fef6 into openconfig:main Dec 23, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RT-1.32 : actions_MED_LocPref_prepend_flow_control_test.go #2767

RT-1.32 : actions_MED_LocPref_prepend_flow_control_test.go #2767

cprabha commented Mar 6, 2024 •

edited

Loading

OpenConfigBot commented Mar 6, 2024 •

edited

Loading

coveralls commented Mar 6, 2024 •

edited

Loading

dplore commented Dec 14, 2024

dplore commented Dec 17, 2024

cprabha commented Dec 17, 2024

dplore commented Dec 17, 2024

dplore commented Dec 20, 2024

dplore left a comment

dplore commented Dec 20, 2024

RT-1.32 : actions_MED_LocPref_prepend_flow_control_test.go #2767

RT-1.32 : actions_MED_LocPref_prepend_flow_control_test.go #2767

Conversation

cprabha commented Mar 6, 2024 • edited Loading

OpenConfigBot commented Mar 6, 2024 • edited Loading

Pull Request Functional Test Report for #2767 / 6229ea0

Virtual Devices

Hardware Devices

coveralls commented Mar 6, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12440249480

Details

💛 - Coveralls

dplore commented Dec 14, 2024

dplore commented Dec 17, 2024

cprabha commented Dec 17, 2024

dplore commented Dec 17, 2024

dplore commented Dec 20, 2024

dplore left a comment

Choose a reason for hiding this comment

dplore commented Dec 20, 2024

cprabha commented Mar 6, 2024 •

edited

Loading

OpenConfigBot commented Mar 6, 2024 •

edited

Loading

Pull Request Functional Test Report for #2767 / `6229ea0`

coveralls commented Mar 6, 2024 •

edited

Loading