-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTG_MTU_1.3: Change the test to pick Destination MAC based on ARP #3045
Merged
Swetha-haridasula
merged 4 commits into
openconfig:main
from
open-traffic-generator:otg_mtu_1.3
Jul 24, 2024
Merged
OTG_MTU_1.3: Change the test to pick Destination MAC based on ARP #3045
Swetha-haridasula
merged 4 commits into
openconfig:main
from
open-traffic-generator:otg_mtu_1.3
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9320822620Details
💛 - Coveralls |
Swetha-haridasula
previously approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Functional Test Report for #3045 / 9307d02Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 10075506440Details
💛 - Coveralls |
Swetha-haridasula
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Jul 25, 2024
…enconfig#3045) * remove dst mac for bound traffic * update file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing test has hardcoded destination mac for bound traffic, removed hardcoded mac and changed to auto which will pick destination mac based on ARP