Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gNMI1.27 #3351

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Fixed gNMI1.27 #3351

merged 9 commits into from
Aug 9, 2024

Conversation

basavarajnokia
Copy link
Contributor

@basavarajnokia basavarajnokia commented Aug 2, 2024

  • Changed to Logf before config
  • Added Deviation
  • Fixed testbed association in metadata.textproto
  • Updated README with OC paths

- Added Deviation
- Fixed testbed association in metadata.textproto

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia\u2019s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
- Changed to Logf before config
- Added Deviation
- Fixed testbed association in metadata.textproto
- Updated README with OC paths

    "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia\u2019s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@basavarajnokia basavarajnokia requested review from a team as code owners August 2, 2024 07:19
@OpenConfigBot
Copy link

OpenConfigBot commented Aug 2, 2024

Pull Request Functional Test Report for #3351 / b8e9dd4

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.27: gNMI Sample Mode Test
Cisco 8000E status
gNMI-1.27: gNMI Sample Mode Test
Cisco XRd status
gNMI-1.27: gNMI Sample Mode Test
Juniper ncPTX status
gNMI-1.27: gNMI Sample Mode Test
Nokia SR Linux status
gNMI-1.27: gNMI Sample Mode Test
Openconfig Lemming status
gNMI-1.27: gNMI Sample Mode Test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-1.27: gNMI Sample Mode Test
Cisco 8808 status
gNMI-1.27: gNMI Sample Mode Test
Juniper PTX10008 status
gNMI-1.27: gNMI Sample Mode Test
Nokia 7250 IXR-10e status
gNMI-1.27: gNMI Sample Mode Test

Help

@basavarajnokia basavarajnokia changed the title gnmi1dot27 Fixed gNMI1.27 Aug 2, 2024
Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10296664340

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%

Totals Coverage Status
Change from base Build 10282148619: 0.0%
Covered Lines: 1983
Relevant Lines: 3573

💛 - Coveralls

@nsadhasivam nsadhasivam merged commit 85f4edf into openconfig:main Aug 9, 2024
13 checks passed
@LimeHat LimeHat deleted the bu-gnmi1dot27 branch August 9, 2024 15:29
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Aug 10, 2024
* - Corrected TestGNMISampleMode as per README
- Added Deviation
- Fixed testbed association in metadata.textproto

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia\u2019s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* - "gNMI-1.27"
- Changed to Logf before config
- Added Deviation
- Fixed testbed association in metadata.textproto
- Updated README with OC paths

    "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia\u2019s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Removed lines 38-47 as per comment from Sergey Fomin as it is a no-op.
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Aug 23, 2024
* - Corrected TestGNMISampleMode as per README
- Added Deviation
- Fixed testbed association in metadata.textproto

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia\u2019s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* - "gNMI-1.27"
- Changed to Logf before config
- Added Deviation
- Fixed testbed association in metadata.textproto
- Updated README with OC paths

    "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia\u2019s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Removed lines 38-47 as per comment from Sergey Fomin as it is a no-op.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants