Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to RT 1.28-BGP to IS-IS redistribution #3359

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

divyarema
Copy link
Contributor

@divyarema divyarema commented Aug 2, 2024

  1. Script is currently replacing the policy without deleting the policy reference in import/export in BGP and in table connections. Updated script to handle this.
  2. Updated community verification with union of string or uint32 based on the yang model

@divyarema divyarema requested review from a team as code owners August 2, 2024 17:46
@OpenConfigBot
Copy link

OpenConfigBot commented Aug 2, 2024

Pull Request Functional Test Report for #3359 / a23c004

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.28: BGP to IS-IS redistribution
Cisco 8000E status
RT-1.28: BGP to IS-IS redistribution
Cisco XRd status
RT-1.28: BGP to IS-IS redistribution
Juniper ncPTX status
RT-1.28: BGP to IS-IS redistribution
Nokia SR Linux status
RT-1.28: BGP to IS-IS redistribution
Openconfig Lemming status
RT-1.28: BGP to IS-IS redistribution

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.28: BGP to IS-IS redistribution
Cisco 8808 status
RT-1.28: BGP to IS-IS redistribution
Juniper PTX10008 status
RT-1.28: BGP to IS-IS redistribution
Nokia 7250 IXR-10e status
RT-1.28: BGP to IS-IS redistribution

Help

@divyarema divyarema marked this pull request as draft August 2, 2024 17:46
@divyarema divyarema marked this pull request as ready for review August 23, 2024 04:23
@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 12081335950

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12081023772: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@dplore dplore removed request for a team September 12, 2024 00:20
@dplore dplore self-assigned this Sep 12, 2024
@dplore
Copy link
Member

dplore commented Nov 8, 2024

/fptest virtual

@dplore
Copy link
Member

dplore commented Nov 21, 2024

/fptest virtual

@ram-mac ram-mac assigned divyarema and unassigned dplore Nov 28, 2024
@ram-mac
Copy link
Contributor

ram-mac commented Nov 28, 2024

Another request though it is not part changes in this PR
If possible please add a space after // for the below mentioned lines.

774 //Create prefix-set
778 //Create community-set
789 //Create tag-set with above route tag value
794 //Route-policy to match tag and accept

@divyarema
Copy link
Contributor Author

Another request though it is not part changes in this PR If possible please add a space after // for the below mentioned lines.

774 //Create prefix-set 778 //Create community-set 789 //Create tag-set with above route tag value 794 //Route-policy to match tag and accept

Taken care of this

@ram-mac ram-mac assigned ram-mac and unassigned divyarema Nov 28, 2024
Copy link
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; Have validated the code and it is working fine.

@ram-mac ram-mac merged commit 4cccbec into openconfig:main Nov 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants