Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-6.1 Fix #3369

Merged
merged 5 commits into from
Aug 13, 2024
Merged

RT-6.1 Fix #3369

merged 5 commits into from
Aug 13, 2024

Conversation

MarcCharlebois
Copy link
Contributor

use GetOrCreate() for lldp interface configs
ref b/358044619


This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.

use GetOrCreate() for lldp interface configs
ref b/358044619
---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>
@MarcCharlebois MarcCharlebois requested review from a team as code owners August 7, 2024 17:29
@OpenConfigBot
Copy link

OpenConfigBot commented Aug 7, 2024

Pull Request Functional Test Report for #3369 / 333a3a4

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-6.1: Core LLDP TLV Population
Cisco 8000E status
RT-6.1: Core LLDP TLV Population
Cisco XRd status
RT-6.1: Core LLDP TLV Population
Juniper ncPTX status
RT-6.1: Core LLDP TLV Population
Nokia SR Linux status
RT-6.1: Core LLDP TLV Population
Openconfig Lemming status
RT-6.1: Core LLDP TLV Population

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-6.1: Core LLDP TLV Population
Cisco 8808 status
RT-6.1: Core LLDP TLV Population
Juniper PTX10008 status
RT-6.1: Core LLDP TLV Population
Nokia 7250 IXR-10e status
RT-6.1: Core LLDP TLV Population

Help

@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10289243414

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%

Totals Coverage Status
Change from base Build 10282148619: 0.0%
Covered Lines: 1983
Relevant Lines: 3573

💛 - Coveralls

---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>
---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>
@MarcCharlebois MarcCharlebois requested a review from a team as a code owner August 7, 2024 17:41
---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>
---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>
Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nsadhasivam nsadhasivam merged commit 60c9722 into openconfig:main Aug 13, 2024
13 checks passed
@LimeHat LimeHat deleted the mc-rt6dot1 branch August 13, 2024 15:53
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Aug 14, 2024
* RT-6.1 Fix

use GetOrCreate() for lldp interface configs
ref b/358044619
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Aug 23, 2024
* RT-6.1 Fix

use GetOrCreate() for lldp interface configs
ref b/358044619
---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>

* fix readme.md

---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>

* sync otg and ate readmes

---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>

* fix incorrect path

---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>

* added same change to otg for tests to be in-sync

---
<sub>This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.</sub>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants