Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-7.5: Remove deviation bgp_conditions_match_community_set_unsupported #3371

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

yini101
Copy link
Contributor

@yini101 yini101 commented Aug 8, 2024

Remove the deviation 'bgp_conditions_match_community_set_unsupported' and update the way to create match-community-set.

@yini101 yini101 requested review from a team as code owners August 8, 2024 04:47
self-maurya
self-maurya previously approved these changes Aug 8, 2024
@coveralls
Copy link

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 12147303670

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12132497399: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@dplore
Copy link
Member

dplore commented Nov 15, 2024

@yini101 please resolve conflicts and we can merge this

@dplore dplore self-assigned this Nov 15, 2024
@dplore
Copy link
Member

dplore commented Nov 19, 2024

/fptest virtual

RT-7.5: Remove deviation bgp_conditions_match_community_set_unsupported
@yini101 yini101 requested a review from dplore as a code owner November 21, 2024 03:36
@yini101 yini101 changed the title RT-7.5: Remove deviation and create match-community-set RT-7.5: Remove deviation bgp_conditions_match_community_set_unsupported Nov 21, 2024
@yini101
Copy link
Contributor Author

yini101 commented Nov 21, 2024

@dplore Thank you for the reminder. I've resolved the merge conflict.

@dplore dplore added P1 Priority 1 nokia-pr labels Nov 28, 2024
@dplore dplore removed the nokia-pr label Dec 3, 2024
@dplore
Copy link
Member

dplore commented Dec 3, 2024

/fptest virtual

@dplore dplore merged commit b38e3bd into openconfig:main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants