fixes issues introduced in PR#2795

[self-maurya]

No description provided.

[OpenConfigBot]

Pull Request Functional Test Report for #3384 / 7ff8639

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-3.7: Base Hierarchical NHG Update	df72f001	Log
Cisco 8000E		TE-3.7: Base Hierarchical NHG Update	1bbe49f0	Log
Cisco XRd		TE-3.7: Base Hierarchical NHG Update	fd12ce77	Log
Juniper ncPTX		TE-3.7: Base Hierarchical NHG Update	b2238a22	Log
Nokia SR Linux		TE-3.7: Base Hierarchical NHG Update	16254b06	Log
Openconfig Lemming		TE-3.7: Base Hierarchical NHG Update	80422399	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TE-3.7: Base Hierarchical NHG Update
Cisco 8808		TE-3.7: Base Hierarchical NHG Update
Juniper PTX10008		TE-3.7: Base Hierarchical NHG Update
Nokia 7250 IXR-10e		TE-3.7: Base Hierarchical NHG Update

Help

[coveralls]

Pull Request Test Coverage Report for Build 10457879270

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 55.252%

---

Totals
Change from base Build 10456235042:	0.0%
Covered Lines:	1983
Relevant Lines:	3589

---

💛 - Coveralls

[cprabha]

@self-maurya pull 2795 only removes interface configuration associating with network instance but not deleting any interface configuration.

Here in this pull we are adding interface config again . but this is not required ?

[LimeHat]

I'd agree with @cprabha , it feels like this should be a deviation for the vendor that needs it.

cc @dplore

[self-maurya]

@self-maurya pull 2795 only removes interface configuration associating with network instance but not deleting any interface configuration.

Here in this pull we are adding interface config again . but this is not required ?

This current setup seems to be working for Juniper as well.
And if I don't remove the vrf-1 then it works for other vendors except Juniper.

Anyways, let me discuss this internally

[cprabha]

be working for Juniper as we

Sure, It will be helpful if this code can be moved under deviation.

[self-maurya]

be working for Juniper as we

Sure, It will be helpful if this code can be moved under deviation.

I had internal discussion with @dplore and few other folks.
As per Darren, the interfaces should be removed from the NI since the delete of the /network-instances/network-instance/ explicitly is a parent of the NI to interface mapping, so the vendor should be removing the interface configs on NI deletion.

@cprabha based on this, could you please raise a PR to introduce a deviation for Juniper.
Sample code

if !deviation {
    // reconfigure the interfaces
}

cc: @dplore