Te 18.6 gRIBI mpls in udp encapsulation for ip sec #3435
Conversation
Pull Request Test Coverage Report for Build 11412151444Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| dst_udp_port: "outer_dst_udp_port" | ||
| ip_ttl: "outer_ip-ttl" | ||
| dscp: "outer_dscp" | ||
| key_chain_name: "ipsec_keychain" |
There was a problem hiding this comment.
add a comment here that updating the OC aft models to support key_chain_name is a TODO item
| } | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Need to add traffic generation profile
Need to add a test procedure with list of steps and validations.
ie:
- send the gribi rpc
- send traffic
- verify packets are ipsec encrypted at ate receive port
Add a negative test case (that confirms traffic not matching is not encrypted/encaped)
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/src-ip: | ||
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/dst-ip: | ||
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/ip-ttl: | ||
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/dst-udp-port: | ||
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/dscp: | ||
| #/network-instances/network-instance/afts/next-hop-groups/next-hop-group/state/next-hop-group-id: |
There was a problem hiding this comment.
these paths shuold be updated to match the newer #1153 model with the encap-headers container
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/dst-udp-port: | ||
| #/network-instances/network-instance/afts/next-hops/next-hop/mpls-in-udp/state/dscp: | ||
| #/network-instances/network-instance/afts/next-hop-groups/next-hop-group/state/next-hop-group-id: | ||
|
|
There was a problem hiding this comment.
are there any paths needed for monitoring ipsec?
| } | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
need to add configuration for adding ipsec keychain and ipsec keys. Provide canonical OC for this.
There was a problem hiding this comment.
Added AFT keychain canonical OC, added TODO's.
vishnureddybadveli
changed the title
Added OC AFT's for keys
No description provided.