SFLOW-1: loopback sub-interface index and handling of source-address when configuring sflow collector #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3445 / dfa8cb5Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 10967717593Details
💛 - Coveralls |
|
/fptest virtual |
self-maurya
approved these changes
Sep 24, 2024
ANISH-GOTTAPU
pushed a commit
to open-traffic-generator/featureprofiles
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrized the loopback sub-interface index; in Juniper's case, loopback sub-interface 0 is typically already configured/present on the device, so reusing that number. For other vendors, left the index as 1 (no change from before).
Removed the defer func where a part of the config used in the test was cleaned up (the NetworkInstance config block). Cleaning up just a part of the config ends up leaving unresolved dependencies behind, causing errors. Also, cleanup of config is typically not done by the tests anyway.
Added support in sflow.go func NewSFlowCollector() to take v4 and v6 source addresses as arguments, to be used when creating the collector instead of picking the address from the loopback interface For vendors that don't support update of source address, picking the source address from the loopback interface is used (no change from before).