Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco zr pm test #3487

Merged
merged 32 commits into from
Nov 19, 2024
Merged

Cisco zr pm test #3487

merged 32 commits into from
Nov 19, 2024

Conversation

karthikeya-remilla
Copy link
Contributor

using a non-zero pre-fec-ber as inactive value when interface is in down state.

adding the associated deviations for it.

@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11917138953

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11913158446: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@rohit-rp
Copy link
Contributor

rohit-rp commented Oct 8, 2024

Kindly resolve conflicts and submit for approval else discard/close the PR if not required.

@self-maurya self-maurya requested a review from amrindrr October 9, 2024 03:38
# Conflicts:
#	proto/metadata.proto
#	proto/metadata_go_proto/metadata.pb.go
@karthikeya-remilla karthikeya-remilla marked this pull request as ready for review October 14, 2024 18:14
@karthikeya-remilla karthikeya-remilla requested a review from a team as a code owner October 14, 2024 18:14
ahsaanyousaf
ahsaanyousaf previously approved these changes Oct 17, 2024
@ahsaanyousaf
Copy link
Contributor

Please resolve the conflicts. Thanks

# Conflicts:
#	internal/deviations/deviations.go
#	proto/metadata.proto
#	proto/metadata_go_proto/metadata.pb.go
ahsaanyousaf
ahsaanyousaf previously approved these changes Nov 6, 2024
Copy link
Contributor

@ahsaanyousaf ahsaanyousaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the conflicts.

# Conflicts:
#	internal/deviations/deviations.go
#	proto/metadata.proto
#	proto/metadata_go_proto/metadata.pb.go
@ahsaanyousaf ahsaanyousaf merged commit 3b524ee into openconfig:main Nov 19, 2024
13 checks passed
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Nov 28, 2024
* uncorrectable_frames deviation

* uncorrectable_frames deviation

* pm + logical-channels deviations

* fec blocks

* revert

* firmware version

* deviation for tunable params test

* error fix

* error fix

* error fix

* error fix

* PR suggestions

* PR changes

* metadata changes

* logical channels changes

* cisco channel changes

* cisco pm test

* update

* cisco update

* update proto files

* fmt

* merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants