-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cisco zr pm test #3487
Merged
ahsaanyousaf
merged 32 commits into
openconfig:main
from
karthikeya-remilla:cisco_zr_pm
Nov 19, 2024
Merged
Cisco zr pm test #3487
ahsaanyousaf
merged 32 commits into
openconfig:main
from
karthikeya-remilla:cisco_zr_pm
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/deviations/deviations.go # proto/metadata.proto # proto/metadata_go_proto/metadata.pb.go
Pull Request Test Coverage Report for Build 11917138953Details
💛 - Coveralls |
Kindly resolve conflicts and submit for approval else discard/close the PR if not required. |
# Conflicts: # proto/metadata.proto # proto/metadata_go_proto/metadata.pb.go
ahsaanyousaf
previously approved these changes
Oct 17, 2024
Please resolve the conflicts. Thanks |
# Conflicts: # internal/deviations/deviations.go # proto/metadata.proto # proto/metadata_go_proto/metadata.pb.go
ahsaanyousaf
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the conflicts.
# Conflicts: # internal/deviations/deviations.go # proto/metadata.proto # proto/metadata_go_proto/metadata.pb.go
ahsaanyousaf
approved these changes
Nov 19, 2024
ANISH-GOTTAPU
pushed a commit
to open-traffic-generator/featureprofiles
that referenced
this pull request
Nov 28, 2024
* uncorrectable_frames deviation * uncorrectable_frames deviation * pm + logical-channels deviations * fec blocks * revert * firmware version * deviation for tunable params test * error fix * error fix * error fix * error fix * PR suggestions * PR changes * metadata changes * logical channels changes * cisco channel changes * cisco pm test * update * cisco update * update proto files * fmt * merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using a non-zero pre-fec-ber as inactive value when interface is in down state.
adding the associated deviations for it.