Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend coverage to verify "INVERT" match option for prefix-set #3501

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rszarecki
Copy link
Contributor

No description provided.

@rszarecki rszarecki requested a review from dplore as a code owner October 7, 2024 20:48
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 7, 2024

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 12509891168

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12509752335: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rszarecki , couple of comments for you.

@dplore dplore self-assigned this Oct 8, 2024
@self-maurya self-maurya requested review from self-maurya and dplore and removed request for self-maurya October 9, 2024 03:30
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the TODO, please add a github issue tracking the implementation of the TODO items

@dplore dplore requested a review from a team as a code owner December 27, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants