Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-2.12 Fixed with deviations & minor changes #3513

Merged
merged 20 commits into from
Dec 3, 2024

Conversation

snaragund
Copy link
Contributor

  • Defined new Nokia deviation 'EnableTableConnections' & updated metadata.proto, metadata.pb.go & deviations.go.
  • Added deviations required.
  • Edited dp2v6Route such that it is advertised as ISIS route.
  • Set separate tag value for IPv4 & IPv6 as per README.
  • Added missing 'metricPropogation' parameter in 2.12.8 case.

PS: Script needs alteration (apart from this PR) such that it adheres to README.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

- Edited dp2v6Route such that it is advertised as ISIS route.
- Set separate tag value for IPv4 & IPv6 as per README.
- Added missing metricPropogation parameter.

PS: Script needs alteration (apart from this PR) such that it adheres to README.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@snaragund snaragund requested review from rohit-rp and a team as code owners October 11, 2024 17:05
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 11, 2024

Pull Request Functional Test Report for #3513 / 9387cce

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-2.12: Static route to IS-IS redistribution
Cisco 8000E status
RT-2.12: Static route to IS-IS redistribution
Cisco XRd status
RT-2.12: Static route to IS-IS redistribution
Juniper ncPTX status
RT-2.12: Static route to IS-IS redistribution
Nokia SR Linux status
RT-2.12: Static route to IS-IS redistribution
Openconfig Lemming status
RT-2.12: Static route to IS-IS redistribution

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-2.12: Static route to IS-IS redistribution
Cisco 8808 status
RT-2.12: Static route to IS-IS redistribution
Juniper PTX10008 status
RT-2.12: Static route to IS-IS redistribution
Nokia 7250 IXR-10e status
RT-2.12: Static route to IS-IS redistribution

Help

snaragund and others added 12 commits October 15, 2024 22:00
- Reverted dp2v6 route

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
O
Merge branch 'SN-RT2dot12' of https://github.com/nokia/featureprofiles into SN-RT2dot12
Merge remote-tracking branch 'upstream/main' into SN-RT2dot12
@dplore dplore self-assigned this Nov 16, 2024
@dplore
Copy link
Member

dplore commented Nov 16, 2024

/fptest virtual

@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 12054508303

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12042434678: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit comments

@dplore
Copy link
Member

dplore commented Nov 16, 2024

Please also check that fptest virtual test passes on your platform as expected

@dplore dplore removed the request for review from rohit-rp November 16, 2024 00:16
@snaragund
Copy link
Contributor Author

/fptest nokia-srl

@snaragund snaragund requested a review from dplore November 17, 2024 18:37
@dplore
Copy link
Member

dplore commented Nov 18, 2024

/fptest virtual

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@snaragund
Copy link
Contributor Author

Shared hardware logs through https://partnerissuetracker.corp.google.com/issues/380289415 please do check.

@dplore dplore merged commit e394152 into openconfig:main Dec 3, 2024
13 checks passed
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
* RT-2.12 Fixed with deviations & minor changes
- Edited dp2v6Route such that it is advertised as ISIS route.
- Set separate tag value for IPv4 & IPv6 as per README.
- Added missing metricPropogation parameter.

PS: Script needs alteration (apart from this PR) such that it adheres to README.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* - Added dut.vendor switch for enable_table_connection deviation.
- Reverted dp2v6 route

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* -Minor change

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Update feature/isis/otg_tests/static_route_isis_redistribution/static_route_isis_redistribution_test.go

Co-authored-by: Darren Loher <[email protected]>

* Update feature/isis/otg_tests/static_route_isis_redistribution/static_route_isis_redistribution_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants