Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export policy test cases to link bandwidth test #3522

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

self-maurya
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11851311028

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11850326151: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@self-maurya self-maurya marked this pull request as ready for review October 17, 2024 14:16
@self-maurya self-maurya requested a review from dplore as a code owner October 17, 2024 14:16
@xw-g xw-g requested a review from rszarecki October 17, 2024 17:00
@rszarecki
Copy link
Contributor

This PR messed up formating of README.md. Can you please fix it.

@self-maurya self-maurya force-pushed the lbw-export branch 3 times, most recently from 7558e45 to b6cb543 Compare October 18, 2024 04:01
@self-maurya self-maurya force-pushed the lbw-export branch 2 times, most recently from 3904be6 to ed1643a Compare October 25, 2024 04:05
@self-maurya self-maurya force-pushed the lbw-export branch 2 times, most recently from 6ce75d1 to 672acc6 Compare November 8, 2024 04:09
Copy link
Contributor

@snaragund snaragund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export-policy mixup has been resolved. Can we remove fptest.LogQuery(t, "", gnmi.OC().RoutingPolicy().Config(), root) at line 844 which prints detailed routing-policy on console, if it is not necessary.

@rszarecki
Copy link
Contributor

/cpbrun

@dplore
Copy link
Member

dplore commented Nov 15, 2024

Export-policy mixup has been resolved. Can we remove fptest.LogQuery(t, "", gnmi.OC().RoutingPolicy().Config(), root) at line 844 which prints detailed routing-policy on console, if it is not necessary.

We think this is needed for troubleshooting if the test fails. It avoids needing to rerun and manual step debugging for bug reports.

@dplore dplore merged commit 9826e0e into openconfig:main Nov 15, 2024
13 checks passed
@self-maurya self-maurya deleted the lbw-export branch November 16, 2024 02:28
mastarkey pushed a commit to b4firex/featureprofiles that referenced this pull request Nov 18, 2024
* Add export policy test cases to link bandwidth test

* update not_match_100_set_linkbw_1M policy to add statement to remove any LBw before adding the new LBw

* added both kbps and KBps comparison

* removed old import and export policies

---------

Co-authored-by: rszarecki <[email protected]>
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Nov 28, 2024
* Add export policy test cases to link bandwidth test

* update not_match_100_set_linkbw_1M policy to add statement to remove any LBw before adding the new LBw

* added both kbps and KBps comparison

* removed old import and export policies

---------

Co-authored-by: rszarecki <[email protected]>
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
* Add export policy test cases to link bandwidth test

* update not_match_100_set_linkbw_1M policy to add statement to remove any LBw before adding the new LBw

* added both kbps and KBps comparison

* removed old import and export policies

---------

Co-authored-by: rszarecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants