Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-1.51: BGP multipath ECMP changes incorporated #3571

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

ampattan
Copy link
Contributor

@ampattan ampattan commented Nov 8, 2024

Updated metadata.textproto

Added deviation enable_multipath_under_afi_safi
Removed deviation explicit_port_speed

Updated bgp_multipath_ecmp_test.go

Added the vendor switch for Nokia, to skipped multipath configuration under peer-group.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Updated metadata.textproto

  Added deviation enable_multipath_under_afi_safi
  Removed deviation explicit_port_speed

Updated bgp_multipath_ecmp_test.go

  Added the vendor switch for Nokia, to skipped multipath configuration under peer-group.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@ampattan ampattan requested a review from dplore as a code owner November 8, 2024 16:51
@OpenConfigBot
Copy link

OpenConfigBot commented Nov 8, 2024

Pull Request Functional Test Report for #3571 / eca9abd

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.51: BGP multipath ECMP
Cisco 8000E status
RT-1.51: BGP multipath ECMP
Cisco XRd status
RT-1.51: BGP multipath ECMP
Juniper ncPTX status
RT-1.51: BGP multipath ECMP
Nokia SR Linux status
RT-1.51: BGP multipath ECMP
Openconfig Lemming status
RT-1.51: BGP multipath ECMP

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.51: BGP multipath ECMP
Cisco 8808 status
RT-1.51: BGP multipath ECMP
Juniper PTX10008 status
RT-1.51: BGP multipath ECMP
Nokia 7250 IXR-10e status
RT-1.51: BGP multipath ECMP

Help

@dplore
Copy link
Member

dplore commented Nov 15, 2024

/fptest virtual

@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11968455809

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11982120871: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@dplore dplore self-assigned this Nov 19, 2024
@dplore dplore added P0 Priority 0 P1 Priority 1 and removed P0 Priority 0 labels Nov 19, 2024
@trathod1
Copy link
Contributor

HW log with these changes are available at - b/380856693

@dplore dplore removed their assignment Dec 3, 2024
@cfernanz cfernanz self-requested a review December 10, 2024 20:28
@cfernanz
Copy link
Contributor

LGTM

@cfernanz cfernanz self-assigned this Dec 10, 2024
@cfernanz cfernanz merged commit d51c0ed into openconfig:main Dec 10, 2024
13 checks passed
alshabib pushed a commit to alshabib/featureprofiles that referenced this pull request Jan 19, 2025
* RT-1.51: BGP multipath ECMP changes incorporated

Updated metadata.textproto

  Added deviation enable_multipath_under_afi_safi
  Removed deviation explicit_port_speed

Updated bgp_multipath_ecmp_test.go

  Added the vendor switch for Nokia, to skipped multipath configuration under peer-group.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Log & comment massage updated.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nokia-pr P1 Priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants