fixing interface level config and timer #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3577 / 88aae9eVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 11793853960Details
💛 - Coveralls |
nsadhasivam
reviewed
Nov 12, 2024
|
|
||
| statePath := isissession.ISISPath(ts.DUT) | ||
| intfName := ts.DUTPort1.Name() | ||
| if deviations.ExplicitInterfaceInDefaultVRF(ts.DUT) { | ||
| intfName += ".0" | ||
| } | ||
| t.Run("ISIS telemetry", func(t *testing.T) { | ||
| time.Sleep(time.Minute * 2) |
There was a problem hiding this comment.
Is the delay for ISIS to come up?
Can we use gnmi.Await instead?
ampattan
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Nov 12, 2024
mastarkey
pushed a commit
to b4firex/featureprofiles
that referenced
this pull request
Nov 18, 2024
ANISH-GOTTAPU
pushed a commit
to open-traffic-generator/featureprofiles
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the adjacency issue by enabling the level 2 at the interface level.
Also added a wait time after the pushing config to the ixia and dut